[SPR-15600] Upgrade to Objenesis 2.6 for Google App Engine Standard on Java 8 and for better JDK 9 support - Spring JIRA

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Complete
Affects Version/s: None
Fix Version/s: 4.3.10, 5.0 RC3
Component/s: Core:AOP
Labels:
None

Last commented by a User:
true

Description

App Engine Standard for Java 8 (currently in Alpha) lifted the old sandbox/API restrictions. We can now use Objenesis as-is. A recent patch was merged into Objensis to take this new environment into account.

See https://github.com/easymock/objenesis/issues/51

This is tracking issue to ensure that Spring core will use the new version when it becomes available on Maven.

Issue Links

is related to

SPR-15668 Jdep issue on org.springframework.objenesis.instantiator.sun.UnsafeFactoryInstantiator

Resolved

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Henri Tremblay added a comment - 22/Jun/17 3:21 PM - edited

Just wanted to add a precision:

Objenesis 2.6 works perfectly on GAE on Java 8
Objenesis 2.6 will behave as it used to on GAE on Java 7 which is
Call no constructor if the class is serializable
Call the no-arg constructor otherwise

And then, there is 3 things I should have mention a long time ago:

Maybe shading Objenesis isn't a good idea. Objenesis has a stable API. It hasn't changed for years. Only the code under the hood is changing. So not shading would allow users to update easily.
Right now, Objenesis is static in ConfigurationClassEnhancer. So there is no way to easily specify a custom strategy even though SpringObjenesis allows it. It would be useful to change that to get flexibility
SpringObjenesis seems to contain some (not all) stuff that could go down in Objenesis directly. I will have a better look but you can file an issue (or PR) about it

Show

Henri Tremblay added a comment - 22/Jun/17 3:21 PM - edited Just wanted to add a precision: Objenesis 2.6 works perfectly on GAE on Java 8 Objenesis 2.6 will behave as it used to on GAE on Java 7 which is Call no constructor if the class is serializable Call the no-arg constructor otherwise And then, there is 3 things I should have mention a long time ago: Maybe shading Objenesis isn't a good idea. Objenesis has a stable API. It hasn't changed for years. Only the code under the hood is changing. So not shading would allow users to update easily. Right now, Objenesis is static in ConfigurationClassEnhancer. So there is no way to easily specify a custom strategy even though SpringObjenesis allows it. It would be useful to change that to get flexibility SpringObjenesis seems to contain some (not all) stuff that could go down in Objenesis directly. I will have a better look but you can file an issue (or PR) about it

7 older comments

Hide

Permalink

Juergen Hoeller added a comment - 26/Jun/17 7:28 PM

Objenesis 2.6 is in Spring Framework master and therefore 5.0.0.BUILD-SNAPSHOT now. I'll keep this ticket open until it's upgraded in the 4.3.x branch as well.

Show

Juergen Hoeller added a comment - 26/Jun/17 7:28 PM Objenesis 2.6 is in Spring Framework master and therefore 5.0.0.BUILD-SNAPSHOT now. I'll keep this ticket open until it's upgraded in the 4.3.x branch as well.

Hide

Permalink

Guillaume Laforge added a comment - 26/Jun/17 8:24 PM

Wonderful, thank you Jürgen!

Show

Guillaume Laforge added a comment - 26/Jun/17 8:24 PM Wonderful, thank you Jürgen!

Hide

Permalink

Phil Webb added a comment - 28/Jun/17 3:39 AM

Juergen Hoeller I've moved the 1.5.5 release date to July 20. It might be a bit of a light release, but I think the dependency upgrade alone makes it worthwhile.

Show

Phil Webb added a comment - 28/Jun/17 3:39 AM Juergen Hoeller I've moved the 1.5.5 release date to July 20. It might be a bit of a light release, but I think the dependency upgrade alone makes it worthwhile.

Hide

Permalink

Guillaume Laforge added a comment - 28/Jun/17 8:53 AM

Good to know about the associated Boot release! Nice!

Show

Guillaume Laforge added a comment - 28/Jun/17 8:53 AM Good to know about the associated Boot release! Nice!

Hide

Permalink

Henri Tremblay added a comment - 28/Jun/17 6:41 PM

While waiting, here is a cute hack to make it work right now. If it can be of any help. It could even go in the real SpringObjenesis.java version. But I'm not sure the shading plugin will like that.

Show

Henri Tremblay added a comment - 28/Jun/17 6:41 PM While waiting, here is a cute hack to make it work right now. If it can be of any help. It could even go in the real SpringObjenesis.java version. But I'm not sure the shading plugin will like that.

People

Assignee:

Juergen Hoeller

Reporter:

Ray Tsang

Last updater:

Stéphane Nicoll

Votes:

1 Vote for this issue

Watchers:

7 Start watching this issue

Dates

Created:

31/May/17 1:42 AM

Updated:

20/Jul/17 12:33 PM

Resolved:

30/Jun/17 1:43 PM

Days since last comment:

11 weeks, 5 days ago

Agile

View on Board