Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-15937

StompDecoder Logs Null Session IDs for Heartbeats

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 4.3.9
    • Fix Version/s: 4.3.11, 5.0 RC4
    • Component/s: Messaging:WebSocket
    • Labels:
      None
    • Last commented by a User:
      true

      Description

      When enabling the TRACE log level on the StompDecoder, a null session id is logged for heartbeats in the Spring WebSocket STOMP client.

      Here is a logging sample:

      11:39:03 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null
      11:39:30 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null
      11:39:31 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null
      11:39:32 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null
      11:39:36 [WebSocketClient-AsyncIO-1] StompDecoder - Decoded heart-beat in session null

        Activity

        Hide
        juergen.hoeller Juergen Hoeller added a comment -

        Ah sorry, I meant to add that we're not logging "with session null" now anymore but rather just "Decoded heart-beat" in such a case.
        Or are you rather wondering about heart-beats without a session in the first place?

        In any case, the commit isn't pushed yet. Coming along with a few others later today.

        Show
        juergen.hoeller Juergen Hoeller added a comment - Ah sorry, I meant to add that we're not logging "with session null" now anymore but rather just "Decoded heart-beat" in such a case. Or are you rather wondering about heart-beats without a session in the first place? In any case, the commit isn't pushed yet. Coming along with a few others later today.
        Hide
        stevedroy Steve Roy added a comment -

        ok - I didn't see the commit so I was wondering what the status was.

        Yes, the pending commit addresses the concern.

        While developing / debugging it raises questions to see a null session id in the log statements. It looks like having the session id available to that location in the code would require some design / code re-organization for a minor issue. Just removing the session id from the log statement helps for now - thank you.

        Show
        stevedroy Steve Roy added a comment - ok - I didn't see the commit so I was wondering what the status was. Yes, the pending commit addresses the concern. While developing / debugging it raises questions to see a null session id in the log statements. It looks like having the session id available to that location in the code would require some design / code re-organization for a minor issue. Just removing the session id from the log statement helps for now - thank you.

          People

          • Assignee:
            juergen.hoeller Juergen Hoeller
            Reporter:
            stevedroy Steve Roy
            Last updater:
            St├ęphane Nicoll
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              2 weeks, 1 day ago