Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-16137

InterceptingHttpAccessor.setInterceptors should support immutable lists

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 5.0 GA, 5.0.1
    • Fix Version/s: 5.0.2
    • Component/s: Web
    • Last commented by a User:
      true

      Description

      When upgrading from org.springframework:spring-web:4.2.4.RELEASE our httpinterceptors stopped working because we used immutable list as input to InterceptingHttpAccessor.setInterceptors. That method now use AnnotationAwareOrderComparator.sort(interceptors) and in extent Collections.sort which is not side effect free.

      InterceptingHttpAccessor.setInterceptors should use a copied list to sort on.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. SPR-13971 Update RestTemplate to respect @Order for ClientHttpRequestInterceptor

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

            Activity

              People

              Assignee:
              juergen.hoeller Juergen Hoeller
              Reporter:
              joaklind Joakim Lindberg
              Last updater:
              Spring Issues Spring Issues
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                3 years, 24 weeks, 1 day ago