Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-16264

Reduce access on user in SimpleBrokerMessageHandler.handleMessageInternal

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 4.3.13
    • Fix Version/s: 4.3.14, 5.0.3
    • Component/s: Messaging:WebSocket
    • Labels:
      None

      Description

      Hi,

      similar to SPR-16165 I found another improvement where unnecessary access to message headers is performed. This time in SimpleBrokerMessageHandler where we look for a user while this is only really needed for CONNECT/DISCONNECT messages. It's not as big as SPR-16165, but I think nonetheless worthwhile.

      The attached PR moves the access on the user header to only CONNECT/DISCONNECT messages in SimpleBrokerMessageHandler.

      I'd appreciate if this PR gets accepted.

      Cheers,
      Christoph

        Attachments

          Activity

            People

            Assignee:
            juergen.hoeller Juergen Hoeller
            Reporter:
            christoph.dreis Christoph Dreis
            Last updater:
            Spring Issues Spring Issues
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Days since last comment:
              3 years, 37 weeks, 6 days ago