Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-17408

Review DataBuffer handling code for proper release in case of error or cancellation

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Complete
    • Affects Version/s: 5.0.10, 5.1.1
    • Fix Version/s: 5.1.2
    • Component/s: Reactive, Web
    • Labels:
      None
    • Last commented by a User:
      true

      Description

      Recent, related efforts on this topic include SPR-17025, SPR-17246, and SPR-16782, but those changes needs some refinement plus a comprehensive review of all DataBuffer handling code with an eye towards error and cancellation signal cases.

      This is an umbrella ticket with sub-tasks:

      1. SPR-17411 DataBufferUtils.
      2. SPR-17410 ReactorServerHttpRequest to drop the onDiscard hook.
      3. SPR-17410 Reactive Streams bridge in spring-web (Servlet, Undertow, HTTP and WebSocket).
      4. SPR-17418 Decoders and message readers.
      5. SPR-17419 Encoders and message writers.
      6. SPR-17424 Jetty ClientHttpConnector.
      7. SPR-17409 Update docs for releasing data buffers on error/cancellation.

      For 4) and 5) above, perhaps we should consider inserting a common onDiscard at the point of using codecs to ensure consistent behavior? Of course individual codecs still need to be able to do the right thing on their own, but perhaps a hint could be passed in to indicate when onDiscard is handled externally..

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rstoya05-aop Rossen Stoyanchev
              Reporter:
              rstoya05-aop Rossen Stoyanchev
              Last updater:
              Spring Issuemaster
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                1 year, 36 weeks, 5 days ago