Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-17560

NettyDataBufferFactory.join should return original buffer as-is in case of a single element (for compatibility with Netty 4.1.32)

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Complete
    • Affects Version/s: 5.0.11, 5.1.3
    • Fix Version/s: 5.0.12, 5.1.4
    • Component/s: Core, Reactive
    • Labels:
      None
    • Last commented by a User:
      true

      Description

      NettyDataBufferFactory.join(List<DataBuffer>) always creates a CompositeByteBuf, even for a single-element list of original buffers. This is generally worth optimizing but particularly necessary for Netty 4.1.32 where CompositeByteBuf is enforced to have at least two elements (see our current HttpServerTests failures on CI).

        Attachments

          Activity

            People

            • Assignee:
              juergen.hoeller Juergen Hoeller
              Reporter:
              juergen.hoeller Juergen Hoeller
              Last updater:
              Spring Issuemaster
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                13 weeks, 3 days ago