Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-5839

Adding trim-capability to property configurers

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 4.3 RC1
    • Component/s: Core
    • Labels:
      None

      Description

      It would be a good option to have for the PropertyOverrideConfigurer and the PropertyPlaceholderConfigurer being able to turn on trimming of property values. This way if the user adds spaces after properties it would not break functionality

        Issue Links

          Activity

          Hide
          rstoya05-aop Rossen Stoyanchev added a comment -

          This issue has been resolved through a selective bulk update, as part of a larger effort to better manage unresolved issues. To qualify for the update, the issue was either created before Spring 3.0 or affects a version older than Spring 3.0 and is not a bug.

          There is a good chance the request was made obsolete, or at least partly outdated, by changes in later versions of Spring including deprecations. It is also possible it didn't get enough traction or we didn't have enough time to address it. One way or another, we didn't get to it.

          If you believe the issue, or some aspects of it, are still relevant and worth pursuing at present you may re-open this issue or create a new one with a more up-to-date description.

          We thank you for your contributions and encourage you to become familiar with the current process of managing Spring Framework JIRA issues that has been in use for over a year.

          Show
          rstoya05-aop Rossen Stoyanchev added a comment - This issue has been resolved through a selective bulk update, as part of a larger effort to better manage unresolved issues. To qualify for the update, the issue was either created before Spring 3.0 or affects a version older than Spring 3.0 and is not a bug. There is a good chance the request was made obsolete, or at least partly outdated, by changes in later versions of Spring including deprecations. It is also possible it didn't get enough traction or we didn't have enough time to address it. One way or another, we didn't get to it. If you believe the issue, or some aspects of it, are still relevant and worth pursuing at present you may re-open this issue or create a new one with a more up-to-date description. We thank you for your contributions and encourage you to become familiar with the current process of managing Spring Framework JIRA issues that has been in use for over a year.
          Hide
          daniilyar Daniil Yaroslavtsev added a comment -

          PropertyPlaceholderConfigurer (and PropertyOverrideConfigurer) still cannot trim propery values (Spring 3.2.0-RELEASE): trailing spaces or '/t' characters after property values in config file are still breaks the functionality.

          Show
          daniilyar Daniil Yaroslavtsev added a comment - PropertyPlaceholderConfigurer (and PropertyOverrideConfigurer) still cannot trim propery values (Spring 3.2.0-RELEASE): trailing spaces or '/t' characters after property values in config file are still breaks the functionality.
          Show
          samuelteixeiras Samuel Araujo Teixeira added a comment - Remove \t and spaces (using trim) https://github.com/samuelteixeiras/spring-framework/commit/f9d66af77f3b5f735e30d55d0c5b7f8a6f669d1c
          Hide
          PrasadShirodkar Prasad Shirodkar added a comment -

          It seems Samuel Araujo Teixeira's fix was only in 3.0.X branch, and not merged into a trunk or mainline branch. The release 3.2.3 does not have this fix. Was there any particular reason this fix was not in the releases following 3.0.x? Can this ticket be expedited?

          Show
          PrasadShirodkar Prasad Shirodkar added a comment - It seems Samuel Araujo Teixeira's fix was only in 3.0.X branch, and not merged into a trunk or mainline branch. The release 3.2.3 does not have this fix. Was there any particular reason this fix was not in the releases following 3.0.x? Can this ticket be expedited?
          Hide
          isabelle.guimiot Isabelle Guimiot added a comment -

          +1
          This improvement would be really helpful !

          Show
          isabelle.guimiot Isabelle Guimiot added a comment - +1 This improvement would be really helpful !
          Hide
          juergen.hoeller Juergen Hoeller added a comment -

          This has finally been added as trim-values flag on <context:property-placeholder> a.k.a setTrimValues(boolean) on the placeholder configurer classes. Sorry that it took so long...

          Juergen

          Show
          juergen.hoeller Juergen Hoeller added a comment - This has finally been added as trim-values flag on <context:property-placeholder> a.k.a setTrimValues(boolean) on the placeholder configurer classes. Sorry that it took so long... Juergen

            People

            • Assignee:
              juergen.hoeller Juergen Hoeller
              Reporter:
              larhire Laura Arhire
              Last updater:
              St├ęphane Nicoll
            • Votes:
              5 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                41 weeks, 1 day ago