Uploaded image for project: 'Spring Framework'
  1. Spring Framework
  2. SPR-6353

TestContext framework should support one AspectJ instance per ApplicationContext

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.5.6, 3.0.5
    • Fix Version/s: General Backlog
    • Component/s: Core:AOP, Test
    • Labels:
      None

      Description

      The Symptom

      • Each test passes when running individually;
      • A few @Transactional tests may fail when running in a test suite. The failure may occur on any @Transactional test class, depending on the nondeterministic runtime tests sequence. In fact, it's quite difficult to reproduce before knowing the root cause.

      Steps to Reproduce

      • Using Spring 2.5.6 or 3.0.0.RC1, JUnit 4;
      • Create a SimpleDbOpService (may or may not annotated with @Transactional), add a method to insert a record into DB based on the input parameters;
      • Create a SimpleDbOpATest:

        @ContextConfiguration({"base.xml", "A.xml"});

      • Create a SimpleDbOpBTest:

        @ContextConfiguration({"base.xml", "B.xml"});

      • Create a SimpleDbOpCTest:

        @ContextConfiguration({"base.xml", "A.xml"});

      • Each test is annotated with @Transactional, calling the SimpleDbOpService and verifying the DB operation results at the end of test method;
      • <tx:annotation-driven mode="aspectj"/> in base.xml, also add "transactionManager" definition in;
      • Create a test suite class as the following:

          import org.junit.runner.RunWith;
          import org.junit.runners.Suite;
          
          @RunWith(Suite.class)
          @Suite.SuiteClasses({
            SimpleDbOpATest.class,
            SimpleDbOpBTest.class,
            SimpleDbOpCTest.class
          })
          public class Debug
          {
          
          }

      • The tests in SimpleDbOpCTest will fail.

      Root Cause

      In the Test Framework, it creates one instance of ApplicationContext for each "Set of context locations" and caches (and switches) the ApplicationContext instances by "context locations". Among all those ApplicationContext instances, the instance of AnnotationTransactionAspect is shared. That is, during the test suite running, there will be only one instance of AnnotationTransactionAspect, no matter how many ApplicationContext instances created.

      A reference to BeanFactory (in spring 3.0.0.RC) or transactionManager (in spring 2.5.6) will be injected into AnnotationTransactionAspect(derived from TransactionAspectSupport) while the ApplicationContext being loaded.

      In the example above, test A and C have the exactly same context locations, and they will share the same application context instance when running in a test suite. So, when running tests A, B, and C in a suite and in that order, the application context instance switches from A to B to A. However, the transactionManager instance (retrieved from an instance of AnnotationTransactionAspect) will be A, B, and B (*should be A though*), because there is only one instance of AnnotationTransactionAspect per classloader. In turn, that causes the operations in the C.testXxx() be split in to two transactionManager instances, one from AnnotationTransactionAspect and the other from ApplicationContext. Therefore, the DB result verification fails.


      Proposed Solution

      To create one Aspect instance per ApplicationContext, not per class loader. Not sure if that's achievable though.


      Further Resources

        Issue Links

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              sbrannen Sam Brannen
              Reporter:
              phantom_john John Wu
              Last updater:
              Juergen Hoeller
            • Votes:
              5 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Days since last comment:
                7 years, 50 weeks, 3 days ago