Spring Framework
  1. Spring Framework
  2. SPR-7123

Migrate Grails BeanBuilder into Spring Core

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 4.0 RC1
    • Component/s: Core:DI
    • Labels:
    • Last commented by a User:
      false

      Description

      The Spring Bean Builder has been extracted from Grails and is being prepared for inclusion in Spring. Much of the development work on the builder itself is done. Work needs to be done to integrate the code into the core spring build.

        Activity

        Hide
        Chris Beams added a comment -

        Jeff, is this still something the Grails team is interested in? The spring-framework build is now happily on Gradle, so should ease the process for you. Let's discuss if you're interested.

        Show
        Chris Beams added a comment - Jeff, is this still something the Grails team is interested in? The spring-framework build is now happily on Gradle, so should ease the process for you. Let's discuss if you're interested.
        Hide
        Jeff Brown added a comment -

        Definitely. I will work up a pull request per our discussion.

        Thanks.

        Show
        Jeff Brown added a comment - Definitely. I will work up a pull request per our discussion. Thanks.
        Show
        Chris Beams added a comment - See Jeff's comments at https://github.com/SpringSource/spring-framework/commit/c463fd0235476c38b108d243a58aad6fe53961de#commitcomment-1775388
        Hide
        Chris Beams added a comment -

        Assigned to myself for review.

        Show
        Chris Beams added a comment - Assigned to myself for review.
        Hide
        Jeff Brown added a comment -

        Chris,

        Are you integrating the lang-groovy subproject into one of the others or are you waiting for me to do that?

        Show
        Jeff Brown added a comment - Chris, Are you integrating the lang-groovy subproject into one of the others or are you waiting for me to do that?
        Hide
        Chris Beams added a comment -

        Thanks for asking - I'm planning to do it.

        Show
        Chris Beams added a comment - Thanks for asking - I'm planning to do it.
        Hide
        Craig Walls added a comment -

        With 3.2.0.RC1 dropping soon and this only existing in a branch, I'm guessing 3.2.0.RC1 won't be seeing Groovy config? Is this a sign that it won't be in 3.2.0 at all? I only ask because I've been asked about this a few times in the past couple of weeks and am not sure how to respond--and honestly, I'd be keen on doing Groovy-based config if it were part of Spring.

        Show
        Craig Walls added a comment - With 3.2.0.RC1 dropping soon and this only existing in a branch, I'm guessing 3.2.0.RC1 won't be seeing Groovy config? Is this a sign that it won't be in 3.2.0 at all? I only ask because I've been asked about this a few times in the past couple of weeks and am not sure how to respond--and honestly, I'd be keen on doing Groovy-based config if it were part of Spring.
        Hide
        Chris Beams added a comment -

        Craig,

        Indeed we had intended to get this in for RC1 but – with apologies to the Grails team – we haven't done so in time. At this point we simply won't have enough time for proper feedback on this in the 3.2 cycle, and so must move it forward to 3.3 (which I'm doing now). I'll be following up with Jeff Brown and Guillaume about this as we move into 3.3, where we're considering various options around promoting Groovy anyway.

        Show
        Chris Beams added a comment - Craig, Indeed we had intended to get this in for RC1 but – with apologies to the Grails team – we haven't done so in time. At this point we simply won't have enough time for proper feedback on this in the 3.2 cycle, and so must move it forward to 3.3 (which I'm doing now). I'll be following up with Jeff Brown and Guillaume about this as we move into 3.3, where we're considering various options around promoting Groovy anyway.
        Hide
        Juergen Hoeller added a comment -

        Finally, we got a cut in Spring Framework master now - based on Jeff's latest pull request but heavily refactored and restructured.

        The public entry points are org.springframework.beans.factory.groovy.GroovyBeanDefinitionReader and org.springframework.context.support.GenericGroovyApplicationContext now, closely modelled after Spring 3.0's GenericXmlApplicationContext and its relationship with XmlBeanDefinitionReader.

        Juergen

        Show
        Juergen Hoeller added a comment - Finally, we got a cut in Spring Framework master now - based on Jeff's latest pull request but heavily refactored and restructured. The public entry points are org.springframework.beans.factory.groovy.GroovyBeanDefinitionReader and org.springframework.context.support.GenericGroovyApplicationContext now, closely modelled after Spring 3.0's GenericXmlApplicationContext and its relationship with XmlBeanDefinitionReader. Juergen

          People

          • Assignee:
            Juergen Hoeller
            Reporter:
            Jeff Brown
            Last updater:
            Phil Webb
          • Votes:
            1 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              26 weeks, 1 day ago