Spring Framework
  1. Spring Framework
  2. SPR-8309

Spring OXM schema improvement for CastorMarshaller

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1 M1
    • Fix Version/s: 3.1 RC1
    • Component/s: OXM
    • Labels:
    • Last commented by a User:
      false

      Description

      I had been working with Werner Guttman lead of the Castor XML project on ideas for extending the Spring OXM for current Castor version. I've prepared a set of patches with change made to Spring OXM schema, that will allow configuring the Castor marshaller using oxm namespace.

      This propsitions will allows to define the marshaller like below i.e.:
      <oxm:castor-marshaller id="marshaller"
      target-class="org.springframework.ws.samples.airline.schema.Flight"
      target-package="org.springframework.ws.samples.airline.schema"
      mapping-location="classpath:mapping.xml"/>

      You will find three patches attached:
      SpringOXM Xml Schema - with changes made in the xsd.
      SpringOXM Xml Schema Implmentation - that contains simple change made in CastorMarshaller and definition of CastorMarshallerBeanDefinitionParser.
      SpringOXM Xml Schema Tests - with tests for CastorMarshallerBeanDefinitionParser

      1. SpringOXM Xml Schema.patch
        2 kB
        Jakub Narloch
      2. SpringOXM Xml Schema 21.05.11.patch
        8 kB
        Jakub Narloch
      3. SpringOXM Xml Schema Implementation.patch
        5 kB
        Jakub Narloch
      4. SpringOXM Xml Schema Implementation 21.05.11.patch
        5 kB
        Jakub Narloch
      5. SpringOXM Xml Schema Implementation 22.05.11.patch
        3 kB
        Jakub Narloch
      6. SpringOXM Xml Schema Tests.patch
        7 kB
        Jakub Narloch
      7. SpringOXM Xml Schema Tests 21.05.11.patch
        7 kB
        Jakub Narloch

        Activity

        Hide
        Jakub Narloch added a comment -

        I uploaded updated patches, that won't cause conflict with CastorMarshaller. I had also reconsidered the previouse idea and decided to add encoding to attribute definition.

        Show
        Jakub Narloch added a comment - I uploaded updated patches, that won't cause conflict with CastorMarshaller. I had also reconsidered the previouse idea and decided to add encoding to attribute definition.
        Hide
        Jakub Narloch added a comment -

        I noticed that I could simplyfile the implementation and use AbstractSimpleBeanDefinitionParser instead. So attached the modified patch.

        To sum up, could You please use:
        SpringOXM Xml Schema 21.05.11.patch
        SpringOXM Xml Schema Implementation 22.05.11.patch
        SpringOXM Xml Schema Tests 21.05.11.patch

        Show
        Jakub Narloch added a comment - I noticed that I could simplyfile the implementation and use AbstractSimpleBeanDefinitionParser instead. So attached the modified patch. To sum up, could You please use: SpringOXM Xml Schema 21.05.11.patch SpringOXM Xml Schema Implementation 22.05.11.patch SpringOXM Xml Schema Tests 21.05.11.patch
        Hide
        Arjen Poutsma added a comment -

        Fixed. Thanks for the patches!

        Show
        Arjen Poutsma added a comment - Fixed. Thanks for the patches!

          People

          • Assignee:
            Arjen Poutsma
            Reporter:
            Jakub Narloch
            Last updater:
            Trevor Marshall
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              2 years, 44 weeks, 5 days ago

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0d
              0d
              Logged:
              Time Spent - 0.05d
              0.05d