Uploaded image for project: 'Spring Tool Suite'
  1. Spring Tool Suite
  2. STS-2184

When importing a webapp project (war, eclipse-wtp), "use hierarchical project names" is not respected when assemblying the Deployment Descriptor

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.8.0.M2
    • Fix Version/s: 3.0.0.M1
    • Component/s: GRADLE
    • Labels:
      None

      Description

      If you import a Gradle multiproject with one of the subprojects using "apply plugin:'war'" and "apply plugin:'eclipse-wtp'", if this depends on other subprojects and "use hierarchical project names" is checked, when building the deployment descriptor those subprojects are mapped without the main project prefix.

      Try the attached project: import all the projects using hierarchical project name. After the import is done, look at the Deployment Descriptor of subproject A (right click on A -> Properties -> Deployment Descriptor).

      1. test_wtp.png
        94 kB

        Activity

        Hide
        d.cavestro Davide Cavestro added a comment -

        @Kris
        You're right, my rushed comment gave you a wrong/misleading info about the incompatibility between java and utility module facets.
        BTW I was experiencing the same issue you've reported: I've never been able to apply the facet manually, even adding a Tomcat Runtime. On the other hand I didn't expect any such need for server runtimes.

        Show
        d.cavestro Davide Cavestro added a comment - @Kris You're right, my rushed comment gave you a wrong/misleading info about the incompatibility between java and utility module facets. BTW I was experiencing the same issue you've reported: I've never been able to apply the facet manually, even adding a Tomcat Runtime. On the other hand I didn't expect any such need for server runtimes.
        Hide
        kdvolder Kris De Volder added a comment -

        Maybe the runtime isn't necessary. I really don't know enough about WTP... and that was purely a conjecture.

        Show
        kdvolder Kris De Volder added a comment - Maybe the runtime isn't necessary. I really don't know enough about WTP... and that was purely a conjecture.
        Hide
        kdvolder Kris De Volder added a comment -

        I'm resolving this as 'won't fix'.

        I will not try to implement something that tries to find references to project names in all the places Gradle might generate them.

        However, a while back I did add some logic to the import wizard to display a warning in cases where there may be a problem (i.e. if running task like 'eclipse' as part of the import and at the same time using the hierarchical names option).

        Show
        kdvolder Kris De Volder added a comment - I'm resolving this as 'won't fix'. I will not try to implement something that tries to find references to project names in all the places Gradle might generate them. However, a while back I did add some logic to the import wizard to display a warning in cases where there may be a problem (i.e. if running task like 'eclipse' as part of the import and at the same time using the hierarchical names option).
        Hide
        mauromol Mauro Molinari added a comment -

        Hi Kris,
        I haven't tested it, but may the resolution of http://issues.gradle.org/browse/GRADLE-1881 in 1.0-rc-1 also fix this problem?

        Show
        mauromol Mauro Molinari added a comment - Hi Kris, I haven't tested it, but may the resolution of http://issues.gradle.org/browse/GRADLE-1881 in 1.0-rc-1 also fix this problem?
        Hide
        kdvolder Kris De Volder added a comment -

        I'm afraid not. The gradle notion of "eclipse project name" is disconnected from sts generated hierarchical names.

        Kris

        Show
        kdvolder Kris De Volder added a comment - I'm afraid not. The gradle notion of "eclipse project name" is disconnected from sts generated hierarchical names. Kris

          People

          • Assignee:
            kdvolder Kris De Volder
            Reporter:
            mauromol Mauro Molinari
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: