Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Complete
    • Affects Version/s: 2.1.0.RELEASE
    • Fix Version/s: Sprint 2, 2.2.0.RELEASE
    • Component/s: None
    • Labels:
      None
    • Environment:
      Windows XP. Eclipse 3.5

      Description

      Currently busy with importing some OSGi projects in my eclipse. What I do is:

      • Import project with Eclipse
      • Add Spring OSGi nature and DM as target runtime
      • Add it to my par project to so my bundle will see my other bundles
      • Build automatically is on so a rebuild is initiated

      Suddenly some of my other open bundles won't compile anymore as they don't see a lot of my common bundles any more (like Hibernate) and indeed my Bundle Repository is missing in my list. When doing a Sprint Tools -> Refresh Bundle Classpath Container the bundle repository is back and its compiling again.

      Please contact me for more info.

        Activity

        Hide
        cdupuis Christian Dupuis added a comment -

        Ric, I triggered another snapshot build that has some changes around thread safety of the repository code. Could please give this build a try and report back. I hope that this fixes the issues that your are seeing but since I can't reproduce you are my only chance.

        Thanks for you patience.

        Christian

        PS: I've reopended the issue since this is blocking you.

        Show
        cdupuis Christian Dupuis added a comment - Ric, I triggered another snapshot build that has some changes around thread safety of the repository code. Could please give this build a try and report back. I hope that this fixes the issues that your are seeing but since I can't reproduce you are my only chance. Thanks for you patience. Christian PS: I've reopended the issue since this is blocking you.
        Hide
        rklaren Ric Klaren added a comment -

        I tried it and it resolves the bundle classpath disappearing problems I can restart eclipse without having to manually fix the build by refreshing classpath containers in build order.

        There are still some cases where a transitive dependency is not rebuild/fixed by refreshing an 'earlier' bundle but that can be due to other problems, I'll log issues for those now this is resolved.

        Thanks very much for the support

        Cheers,

        Ric

        Show
        rklaren Ric Klaren added a comment - I tried it and it resolves the bundle classpath disappearing problems I can restart eclipse without having to manually fix the build by refreshing classpath containers in build order. There are still some cases where a transitive dependency is not rebuild/fixed by refreshing an 'earlier' bundle but that can be due to other problems, I'll log issues for those now this is resolved. Thanks very much for the support Cheers, Ric
        Hide
        cdupuis Christian Dupuis added a comment -

        Ric, thanks for confirming that this indeed fixes your problem.

        With regards to the transitive dependency refresh problem you are mentioning there is already an open JIRA at:

        STS-396: If I fix build path issues with Refresh Bundle Classpath Container only direct descendants get their issues fixed as well
        https://issuetracker.springsource.com/browse/STS-396

        Is that correctly reflecting the issue that you're talking about.

        Christian

        Show
        cdupuis Christian Dupuis added a comment - Ric, thanks for confirming that this indeed fixes your problem. With regards to the transitive dependency refresh problem you are mentioning there is already an open JIRA at: STS-396 : If I fix build path issues with Refresh Bundle Classpath Container only direct descendants get their issues fixed as well https://issuetracker.springsource.com/browse/STS-396 Is that correctly reflecting the issue that you're talking about. Christian
        Hide
        rklaren Ric Klaren added a comment -

        That's the one although my impression so far is that it improved greatly with this fix, I wanted to play around a bit more before confirming it in that one.

        I now have some other weird problems with package imports being visible in one bundle and not in another (while it is imported in the manifest even a require bundle on the offending bundle does not help) switching between project and maven artifact seems not to matter. Although another project appears twice in the bundle manifest container, I'll open another ticket for that issue (probably later today/tomorow have to switch to some other tasks for today).

        Aside note: a new option appeared in the snapshot Preferences -> Spring ->Manifest Generation -> Scan output folders which is enabled by default. This pretty much makes the bundlor generated manifests useless, it misses a lot of packages. Often direct imports of classes (but this happens often yet inconsistently). To work around the lack of template.mf syntax for TEST.MF only imports we use some dummy java files that import something from the necessary packages, these get missed more often with this option turned on. (When it works it works perfectly though)

        Show
        rklaren Ric Klaren added a comment - That's the one although my impression so far is that it improved greatly with this fix, I wanted to play around a bit more before confirming it in that one. I now have some other weird problems with package imports being visible in one bundle and not in another (while it is imported in the manifest even a require bundle on the offending bundle does not help) switching between project and maven artifact seems not to matter. Although another project appears twice in the bundle manifest container, I'll open another ticket for that issue (probably later today/tomorow have to switch to some other tasks for today). Aside note: a new option appeared in the snapshot Preferences -> Spring ->Manifest Generation -> Scan output folders which is enabled by default. This pretty much makes the bundlor generated manifests useless, it misses a lot of packages. Often direct imports of classes (but this happens often yet inconsistently). To work around the lack of template.mf syntax for TEST.MF only imports we use some dummy java files that import something from the necessary packages, these get missed more often with this option turned on. (When it works it works perfectly though)
        Hide
        cdupuis Christian Dupuis added a comment -

        In reply to comment #19:

        > I now have some other weird problems with package imports being visible in one
        > bundle and not in another (while it is imported in the manifest even a require
        > bundle on the offending bundle does not help) switching between project and
        > maven artifact seems not to matter. Although another project appears twice in
        > the bundle manifest container, I'll open another ticket for that issue (probably
        > later today/tomorow have to switch to some other tasks for today).

        Yes, please open a JIRA with some details to reproduce this.

        > > Aside note: a new option appeared in the snapshot Preferences -> Spring
        > ->Manifest Generation -> Scan output folders which is enabled by default. This
        > pretty much makes the bundlor generated manifests useless, it misses a lot of
        > packages. Often direct imports of classes (but this happens often yet
        > inconsistently). To work around the lack of template.mf syntax for TEST.MF only
        > imports we use some dummy java files that import something from the necessary
        > packages, these get missed more often with this option turned on. (When it works
        > it works perfectly though)

        This is a new option which uses Bundlor default byte-code scanning on project output folders. As you are using a nightly build it could be that there are still issues with this new feature. If you experience issues please let me know with details on how to reproduce and I'll take a look.

        There might be something special with your project setup that some classes or so are not being scanned. Right now I iterate over all output folders (project's default + output folder for each source folder) and scan that using default Bundlor byte-code scanning. Are you only using project source folders or do you use some kind of linking?

        Christian

        Show
        cdupuis Christian Dupuis added a comment - In reply to comment #19: > I now have some other weird problems with package imports being visible in one > bundle and not in another (while it is imported in the manifest even a require > bundle on the offending bundle does not help) switching between project and > maven artifact seems not to matter. Although another project appears twice in > the bundle manifest container, I'll open another ticket for that issue (probably > later today/tomorow have to switch to some other tasks for today). Yes, please open a JIRA with some details to reproduce this. > > Aside note: a new option appeared in the snapshot Preferences -> Spring > ->Manifest Generation -> Scan output folders which is enabled by default. This > pretty much makes the bundlor generated manifests useless, it misses a lot of > packages. Often direct imports of classes (but this happens often yet > inconsistently). To work around the lack of template.mf syntax for TEST.MF only > imports we use some dummy java files that import something from the necessary > packages, these get missed more often with this option turned on. (When it works > it works perfectly though) This is a new option which uses Bundlor default byte-code scanning on project output folders. As you are using a nightly build it could be that there are still issues with this new feature. If you experience issues please let me know with details on how to reproduce and I'll take a look. There might be something special with your project setup that some classes or so are not being scanned. Right now I iterate over all output folders (project's default + output folder for each source folder) and scan that using default Bundlor byte-code scanning. Are you only using project source folders or do you use some kind of linking? Christian

          People

          • Assignee:
            Unassigned
            Reporter:
            vkok Vincent Kok
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5d
              0.5d
              Remaining:
              Remaining Estimate - 0d
              0d
              Logged:
              Time Spent - 0.5d
              0.5d