Details
-
Type:
Improvement
-
Status: Resolved
-
Priority:
Major
-
Resolution: Complete
-
Affects Version/s: 2.3.0
-
Fix Version/s: 2.4.0.M1
-
Component/s: Binding: Validation System
-
Labels:None
Description
JSR-303 allows an array of validation groups (specified as Java types) to be passed in order to validate a subset of the constraints specified on a model object. This is useful in cases where the current user only updates a certain 'group' of properties on the model object and validation must be performed before proceeding.
SWF 2.3.0 currently does not contain an API to specify validation groups on the model object for JSR-303 validation. However, this feature would be very useful.
Issue Links
- depends on
-
SPR-7062
Add Group Class support to JSR-303 Validation using @Valid
-
- Resolved
-
Activity
Support for this is now in master. Hints can be added as follows:
<view-state id="state1" model="myModel" validation-hints="group1,group2">
Each hint can be an inner Class either in the model type or its parent types, or a fully qualified class name. The hint "default" is reserved as the default validation group, i.e. javax.validation.groups.Default. The validation-hints property is an expression that can resolve to a String or an Object[] with Class instances. A custom ValidationHintResolver can also be plugged in through the flow-builder-services element to extend or replace the above algorithm.
Rossen Stoyanchev
added a comment - Support for this is now in master. Hints can be added as follows:
<view-state id= "state1" model= "myModel" validation-hints= "group1,group2" >
Each hint can be an inner Class either in the model type or its parent types, or a fully qualified class name. The hint "default" is reserved as the default validation group, i.e. javax.validation.groups.Default . The validation-hints property is an expression that can resolve to a String or an Object[] with Class instances. A custom ValidationHintResolver can also be plugged in through the flow-builder-services element to extend or replace the above algorithm. In your example you forgot the single quotes:
<view-state id="state1" model="myModel" validation-hints="'group1,group2'">
Sebastian Davids
added a comment - In your example you forgot the single quotes:
<view-state id= "state1" model= "myModel" validation-hints= "'group1,group2'" >
Why is the hints on the view-state? Shouldn't that be on the transition? You could have different validation requirement depending on the transition.
I agree with Frank Liu I can really benefit from a validation-hint at transition level ( logic could be if you specify both, the transition hint override the the view level hint ).
Should I open a request enhancement?
I imagine it in AbstractMvcView.getValidationHints(...) it has to execute getCurrenTransition() and read from that if there is the new attribute validationHint. I'm not an expert of spring inner logic but at first glance it does not seems complex.
Massimo Franzoni
added a comment - I agree with Frank Liu I can really benefit from a validation-hint at transition level ( logic could be if you specify both, the transition hint override the the view level hint ).
Should I open a request enhancement?
I imagine it in AbstractMvcView.getValidationHints(...) it has to execute getCurrenTransition() and read from that if there is the new attribute validationHint. I'm not an expert of spring inner logic but at first glance it does not seems complex. Iam migrating my spring mvc application to use spring webflow and Iam seeing this limitation as show stopper. Is there any plan to fix this issue ?
Here is my situation .....
Iam using tabbed pane jsp page and on each tab I have an update button. On click of update button on particular tab, corresponding data need tobe validated.If it is a wizard kind of pages I would have navigated to different view states based on next/back buttons but since it is a single view state and has different transitions for each update button
<view-state id="showOperatorDetails" view="operator.view" model="operatorForm" validation-hints="'Personal,Educational,Business'">
<on-render>
<evaluate expression="operatorController.setModelAttributes(operatorForm)" />
</on-render>
<transition on="cancel" to="end" validate="false"/>
<transition on="updatePersonal" >
<evaluate expression="operatorController.updatePersonal(operatorForm)"/>
</transition>
<transition on="updateEducational" >
<evaluate expression="operatorController.updateEducational(operatorForm)"/>
</transition>
<transition on="updateBusiness" >
<evaluate expression="operatorController.updateBusiness(operatorForm)"/>
</transition>
</view-state>
Arif Mohammed
added a comment - Iam migrating my spring mvc application to use spring webflow and Iam seeing this limitation as show stopper. Is there any plan to fix this issue ?
Here is my situation .....
Iam using tabbed pane jsp page and on each tab I have an update button. On click of update button on particular tab, corresponding data need tobe validated.If it is a wizard kind of pages I would have navigated to different view states based on next/back buttons but since it is a single view state and has different transitions for each update button
<view-state id="showOperatorDetails" view="operator.view" model="operatorForm" validation-hints="'Personal,Educational,Business'">
<on-render>
<evaluate expression="operatorController.setModelAttributes(operatorForm)" />
</on-render>
<transition on="cancel" to="end" validate="false"/>
<transition on="updatePersonal" >
<evaluate expression="operatorController.updatePersonal(operatorForm)"/>
</transition>
<transition on="updateEducational" >
<evaluate expression="operatorController.updateEducational(operatorForm)"/>
</transition>
<transition on="updateBusiness" >
<evaluate expression="operatorController.updateBusiness(operatorForm)"/>
</transition>
</view-state> 
Web Flow relies on MVC SpringValidatorAdapter.validate(Object, Errors) for JSR 303 Bean Validation. It may be possible to provide some intermediate solution ahead of the Spring 3.1 final release. However we'd most likely need to wait for Spring 3.1 M2 at least to see the changes in SpringValidatorAdapter (
SPR-7062).