Spring Web Flow
  1. Spring Web Flow
  2. SWF-1527

Spring Web Flow works with PrimeFaces 2.2.1, but not 3.X

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Cannot Reproduce
    • Affects Version/s: 2.3.0, 2.3.1
    • Fix Version/s: None
    • Component/s: JSF

      Description

      Starting with the booking-faces example (2.3.0) as a basis, the project may be upgraded to latest production Spring Security, Framwork, JSF and (as late as) BUILD-20120306.231817-8 of SWF, which will work with PrimeFaces 2.2.1, but not any 3.x. Prime Faces is a zero-config, one-jar product, so how can this be so?

      Test is build booking-faces with new stacks, navigate to ViewHotels.xhtml, note pager fail.

      Other related threads,

      Testing matrix, sample apps attached.

      1. booking-faces.tgz
        190 kB
        Scott Maines
      2. booking-faces-2.2.1-plus.tgz
        191 kB
        Scott Maines
      3. booking-faces-2.2.1-ultraplus.tgz
        193 kB
        Scott Maines
      4. booking-faces-3.0.1-plus.tgz
        191 kB
        Scott Maines
      5. booking-faces-3.1.1-uberplus.tgz
        191 kB
        Scott Maines
      6. booking-faces-3.1.1-ultraplus.tgz
        193 kB
        Scott Maines
      7. booking-faces-3.1.tgz
        190 kB
        Scott Maines
      8. booking-faces-3.1-plus.tgz
        191 kB
        Scott Maines
      9. booking-faces-3.1-uberplus.tgz
        191 kB
        Scott Maines
      10. booking-faces-matrix.pdf
        17 kB
        Scott Maines

        Issue Links

          Activity

          Hide
          Rossen Stoyanchev added a comment -

          The booking-faces sample was upgraded (very recently) to PF 3.1.1 (SWF-1523). Would you mind giving it another try with the latest 2.3.1 snapshot? Thanks.

          Show
          Rossen Stoyanchev added a comment - The booking-faces sample was upgraded (very recently) to PF 3.1.1 ( SWF-1523 ). Would you mind giving it another try with the latest 2.3.1 snapshot? Thanks.
          Hide
          Scott Maines added a comment - - edited

          Had a quick look. Just tried what I pulled off the trunk from git,

          1) mvn clean jetty:run blows up with "java.lang.IllegalStateException: Could not find backup for factory javax.faces.lifecycle.LifecycleFactory".

          2) mvn clean tomcat:run doesn't forward correctly off http://localhost:8080, but forwards with http://localhost:8080/booking-faces/, and does paginate correctly.

          Also,

          3) Simply running my upgraded booking-faces-2.3.0 example against SWF.BUILD-SNAPSHOT fails. I need to study the diffs more closely to understand whether there is new configuration needed, or the change from referencing searchCritera to hotels (with the pass-thru getters added in Hotels) is motivated by other than mere elective refactoring.

          BTW, am I safe in assuming that .classpath, .springBeans, and .springWebFlow doesn't actually affect a pure maven build, but is only an STS thing?

          More later,

          -SM

          Show
          Scott Maines added a comment - - edited Had a quick look. Just tried what I pulled off the trunk from git, 1) mvn clean jetty:run blows up with "java.lang.IllegalStateException: Could not find backup for factory javax.faces.lifecycle.LifecycleFactory". 2) mvn clean tomcat:run doesn't forward correctly off http://localhost:8080 , but forwards with http://localhost:8080/booking-faces/ , and does paginate correctly. Also, 3) Simply running my upgraded booking-faces-2.3.0 example against SWF.BUILD-SNAPSHOT fails. I need to study the diffs more closely to understand whether there is new configuration needed, or the change from referencing searchCritera to hotels (with the pass-thru getters added in Hotels) is motivated by other than mere elective refactoring. BTW, am I safe in assuming that .classpath, .springBeans, and .springWebFlow doesn't actually affect a pure maven build, but is only an STS thing? More later, -SM
          Hide
          Scott Maines added a comment - - edited

          When I changed my upgraded example (as you have done) to refernce page and size through the hotels variable, my upgrades worked even with swf 2.3.0.RELEASE and the FlowFacesContext patch (needed, I think, for JSF 2.1+).

          My grasp of SWF is not subtle enough to know whether this refactoring masked a real problem, but I suppose the example was just miscoded to begin with (in referencing searchCriteria in the DataTable tag), given the possible JSF events passed to PF.

          Show
          Scott Maines added a comment - - edited When I changed my upgraded example (as you have done) to refernce page and size through the hotels variable, my upgrades worked even with swf 2.3.0.RELEASE and the FlowFacesContext patch (needed, I think, for JSF 2.1+). My grasp of SWF is not subtle enough to know whether this refactoring masked a real problem, but I suppose the example was just miscoded to begin with (in referencing searchCriteria in the DataTable tag), given the possible JSF events passed to PF.
          Hide
          Rossen Stoyanchev added a comment -

          Had a quick look. Just tried what I pulled off the trunk from git

          I meant just changing your pom.xml to use 2.3.1.BUILD-SNAPSHOT as the version for Web Flow artifacts. But if you want to use the code from github, the 2.3.1 branch is where the changes are, the master branch doesn't have them yet.

          I just tried switching back to searchCriteria and it worked fine as well. Other than that it makes more sense to encapsulate the use of SearchCriteria in the HotelLazyDataModel as the current version does.

          Show
          Rossen Stoyanchev added a comment - Had a quick look. Just tried what I pulled off the trunk from git I meant just changing your pom.xml to use 2.3.1.BUILD-SNAPSHOT as the version for Web Flow artifacts. But if you want to use the code from github, the 2.3.1 branch is where the changes are, the master branch doesn't have them yet. I just tried switching back to searchCriteria and it worked fine as well. Other than that it makes more sense to encapsulate the use of SearchCriteria in the HotelLazyDataModel as the current version does.
          Hide
          Scott Maines added a comment - - edited

          I did understand, though I misspoke: I pulled from github the head of the 2.3.x branch, there being no 2.3.1 branch or tag I could find. I took both the example as it was in that branch, AND separately tried upgrading the original 2.3.0 booking-faces example (pom.xml, code, etc). My primary concern was that such an upgrade should have been simple, yet things were (repeatably) amiss, so I wanted to repeat the exercise from there.

          I'm content that this be marked as resolved.

          Show
          Scott Maines added a comment - - edited I did understand, though I misspoke: I pulled from github the head of the 2.3.x branch, there being no 2.3.1 branch or tag I could find. I took both the example as it was in that branch, AND separately tried upgrading the original 2.3.0 booking-faces example (pom.xml, code, etc). My primary concern was that such an upgrade should have been simple, yet things were (repeatably) amiss, so I wanted to repeat the exercise from there. I'm content that this be marked as resolved.
          Hide
          Rossen Stoyanchev added a comment -

          I see. The 2.3.1 release is out now. We'll be making some changes soon to the build and also moving the examples out into a separate repository so the process you went through should become simpler.

          Show
          Rossen Stoyanchev added a comment - I see. The 2.3.1 release is out now. We'll be making some changes soon to the build and also moving the examples out into a separate repository so the process you went through should become simpler.

            People

            • Assignee:
              Rossen Stoyanchev
              Reporter:
              Scott Maines
            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development