Uploaded image for project: 'Spring Web Flow'
  1. Spring Web Flow
  2. SWF-1620

No exception handling for fireRequestProcessed in FlowExecutionImpl.start and FlowExecutionImpl.resume

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Works as Designed
    • 2.3.1, 2.3.2, 2.4.0.M1
    • None
    • Core: Flow Executor

    Description

      There is no exception handling in

      FlowExecutionImpl.start and FlowExecutionImpl.resume
      for row listeners.fireRequestProcessed(requestContext);

      The exception is only logged as an error but there is no exception handling:

      try {
           listeners.fireRequestProcessed(requestContext);
      } catch (Throwable e) {
           logger.error("FlowExecutionListener threw exception", e);
      }
      

      RequestContextHolder.setRequestContext(null)

      Could this be a solution for the problem?

      try {
          listeners.fireRequestProcessed(requestContext);
      
      } catch (Throwable e) {
          logger.error("FlowExecutionListener threw exception", e);
          if (e instanceof Exception) {
              handleException(wrap((Exception) e), requestContext);
          }
      } finally {
          RequestContextHolder.setRequestContext(null);
      }
      

      Attachments

        Activity

          People

            rstoya05-aop Rossen Stoyanchev
            galda Sebastian Galda
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: