Uploaded image for project: 'Spring Web Flow'
  1. Spring Web Flow
  2. SWF-1705

combination of SWF and MyFaces Trinidad may set flag 'JsfRuntimeInformation.myFacesInUse' to wrong value

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Complete
    • Affects Version/s: 2.4.5
    • Fix Version/s: 2.4.6, 2.5.RC1
    • Component/s: JSF
    • Labels:
      None

      Description

      If combination of SWF and MyFaces Trinidad is used, the flag JsfRuntimeInformation.myFacesInUse may be set to wrong value in method JsfRuntimeInformation.isMyFacesInUse().

      Reason: facesContext.getClass() may be org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl$CacheRenderKit (depending on the order of wrapped FacesContexts) which is interpreted as "MyFaces Core" by code

      facesContext.getClass().getPackage().getName().startsWith("org.apache.myfaces.")
      

      Bet solution of solving this inside method JsfRuntimeInformation.isMyFacesInUse() seem to be:
      walk through a potential stack of FacesContextWrapper instances until you reach a non-FacesContextWrapper FacesContext which should be good for deciding if it's MyFaces Core or not.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rstoya05-aop Rossen Stoyanchev
              Reporter:
              malzahn Volker Malzahn
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: