Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0 RC1
    • Fix Version/s: 1.0 RC2
    • Component/s: Documentation
    • Labels:
      None

      Description

      It would be nice if a native speaker could review the written documentation before 1.0 final.

        Activity

        Hide
        corbathegeek Corba the Geek added a comment -

        The latest chapters are a great addition. In the process of reading through chapters 2 through 5, I've added notes to the latest .pdf file about misspellings, grammatical errors and usage suggestions.

        Show
        corbathegeek Corba the Geek added a comment - The latest chapters are a great addition. In the process of reading through chapters 2 through 5, I've added notes to the latest .pdf file about misspellings, grammatical errors and usage suggestions.
        Hide
        springboy Rick Evans added a comment -

        Hi Corba

        Thanks for taking the time to annotate the documentation with comments and stuff, it is really appreciated... I am in the process of folding your edits into the source documents.

        Cheers
        Rick

        Show
        springboy Rick Evans added a comment - Hi Corba Thanks for taking the time to annotate the documentation with comments and stuff, it is really appreciated... I am in the process of folding your edits into the source documents. Cheers Rick
        Hide
        springboy Rick Evans added a comment -

        Fixed.

        Thanks for taking the time to annotate the documentation with the corrections; nice work.

        I have corrected all of the errors that you pointed out, and I have put markers in place to handle some of the bigger issues you pointed out (like add an appendix).

        One of your comments in the annotated document was about the favouring of constructor-injection over setter-injection in the examples.

        I'll refer you to the main Spring reference documentation for the answer. If you click on this link and scroll a little (half a page or so) down, you will see a sidebar entitled 'Constructor- or Setter-based DI?', which explains the Spring teams view (not unanimous it must be added) about this topic.

        http://static.springframework.org/spring/docs/2.0.x/reference/beans.html#beans-factory-collaborators

        Hope that helps.

        Cheers
        Rick

        Show
        springboy Rick Evans added a comment - Fixed. Thanks for taking the time to annotate the documentation with the corrections; nice work. I have corrected all of the errors that you pointed out, and I have put markers in place to handle some of the bigger issues you pointed out (like add an appendix). One of your comments in the annotated document was about the favouring of constructor-injection over setter-injection in the examples. I'll refer you to the main Spring reference documentation for the answer. If you click on this link and scroll a little (half a page or so) down, you will see a sidebar entitled 'Constructor- or Setter-based DI?', which explains the Spring teams view (not unanimous it must be added) about this topic. http://static.springframework.org/spring/docs/2.0.x/reference/beans.html#beans-factory-collaborators Hope that helps. Cheers Rick
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing 1.0 RC2 issues.

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing 1.0 RC2 issues.

          People

          • Assignee:
            springboy Rick Evans
            Reporter:
            arjen.poutsma Arjen Poutsma
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: