Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-123

CommonsHttpMessageSender should expose setters for username and password

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0 RC1
    • Fix Version/s: 1.0 RC2
    • Component/s: Core
    • Labels:
      None

      Description

      Assuming that CommonsHttpMessageSender is often used for it's authentication support, it would be convenient if it exposed setters for a username and password (AuthScope should default to AuthScope.ANY).

        Activity

        Hide
        ralph.poellath Ralph Pöllath added a comment -

        Attached a patch that implements convenient setters for username and password.

        Since I couldn't get Spring-WS to build properly, this patch is untested.

        Show
        ralph.poellath Ralph Pöllath added a comment - Attached a patch that implements convenient setters for username and password. Since I couldn't get Spring-WS to build properly, this patch is untested.
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Thanks for the patch!

        I will change it slightly, though: rather than only allowing username/password authentication, I will allow a Credentials instance to be injected, and also the AuthenticationScope. This allows it to be used with NTLM authentication as well.

        Show
        arjen.poutsma Arjen Poutsma added a comment - Thanks for the patch! I will change it slightly, though: rather than only allowing username/password authentication, I will allow a Credentials instance to be injected, and also the AuthenticationScope. This allows it to be used with NTLM authentication as well.
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Fixed: CommonsHttpMessageSender has a Credentials property now, where you can inject a UsernamePasswordCredentials.

        Show
        arjen.poutsma Arjen Poutsma added a comment - Fixed: CommonsHttpMessageSender has a Credentials property now, where you can inject a UsernamePasswordCredentials.
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing 1.0 RC2 issues.

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing 1.0 RC2 issues.

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            ralph.poellath Ralph Pöllath
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: