Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-126

WebServiceMessageCallback's doInMessage() method is (possibly) poorly named.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0 RC1
    • Fix Version/s: 1.0 RC2
    • Component/s: Core
    • Labels:
      None

      Description

      The WebServiceMessageCallback has a single method with the following signature:

      void doInMessage(WebServiceMessage message) throws IOException;

      I think it is poorly named, because you are not actually 'in' the message. You are rather doing something 'with' the message. I think the method would be better off looking like this:

      void doWithMessage(WebServiceMessage message) throws IOException;

        Activity

        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing 1.0 RC2 issues.

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing 1.0 RC2 issues.

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            springboy Rick Evans
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: