Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0, 1.0.1
    • Fix Version/s: 1.0.2
    • Component/s: None
    • Labels:
      None

      Description

      Use Assert.isInstanceOf rather than Assert.isTrue

      This...
      Assert.isTrue(messageContext.getResponse() instanceof SoapMessage, "SimpleSoapExceptionResolver requires a SoapMessage");

      Should be this...
      Assert.isInstanceOf(SoapMessage.class, messageContext.getResponse(), "SimpleSoapExceptionResolver requires a SoapMessage");

      Just an observation

        Activity

        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Thanks, I didn't even know that Assert.isInstanceOf existed!

        Show
        arjen.poutsma Arjen Poutsma added a comment - Thanks, I didn't even know that Assert.isInstanceOf existed!
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing 1.0.2 issues.

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing 1.0.2 issues.

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            raykrueger Ray Krueger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: