Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-216

AbstractValidatingInterceptor.handleResponseValidationErrors's JavaDoc is wrong

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.0.2
    • Component/s: Core
    • Labels:
      None
    • Environment:
      N/A

      Description

      AbstractValidatingInterceptor.handleResponseValidationErrors's JavaDoc states the following:
      /**

      • Template method that is called when the response message contains validation errors. Default implementation logs
      • all errors, and returns <code>false</code>, i.e. do not send the response.
        *
      • @param messageContext the message context
      • @param errors the validation errors @return <code>true</code> to continue sending the response,
      • <code>false</code> (the default) otherwise
        */

      However, returning false here doesn't mean that the response won't be send. It means that the rest of the Interceptor chain won't be processed and that the response will be send out immediately (see MessageDispatcher.triggerHandleResponse). The docs should be changed to represent the actual behaviour.

        Attachments

          Activity

            People

            • Assignee:
              arjen.poutsma Arjen Poutsma
              Reporter:
              jkuipers Joris Kuipers
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0.25h
                0.25h
                Remaining:
                Remaining Estimate - 0.25h
                0.25h
                Logged:
                Time Spent - Not Specified
                Not Specified