Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-400

Make AbstractLoggingInterceptor more extensible

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Complete
    • Affects Version/s: 1.5.3
    • Fix Version/s: 2.4.1
    • Component/s: Core
    • Labels:
      None

      Description

      PayloadLoggingInterceptor (via AbstractLoggingInterceptor) logs all the payload in debug level.
      I tried to change this behavior by subclassing PayloadLoggingInterceptor. But I could not override the method AbstractLoggingInterceptor.handleRequest because it is declared as final.
      The simple solution would be to remove the final keyword.
      But in my opinion an AbstractLoggingInterceptor shoud be more flexible e.g. for different log levels.

        Activity

        Hide
        mzeibig Mirko Zeibig added a comment -

        Attached a patch to change some visibilities.

        Show
        mzeibig Mirko Zeibig added a comment - Attached a patch to change some visibilities.
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing old issues

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing old issues

          People

          • Assignee:
            gregturn Greg Turnquist
            Reporter:
            mzeibig Mirko Zeibig
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: