Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-400

Make AbstractLoggingInterceptor more extensible

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Complete
    • Affects Version/s: 1.5.3
    • Fix Version/s: 2.4.1
    • Component/s: Core
    • Labels:
      None

      Description

      PayloadLoggingInterceptor (via AbstractLoggingInterceptor) logs all the payload in debug level.
      I tried to change this behavior by subclassing PayloadLoggingInterceptor. But I could not override the method AbstractLoggingInterceptor.handleRequest because it is declared as final.
      The simple solution would be to remove the final keyword.
      But in my opinion an AbstractLoggingInterceptor shoud be more flexible e.g. for different log levels.

        Activity

        mzeibig Mirko Zeibig created issue -
        arjen.poutsma Arjen Poutsma made changes -
        Field Original Value New Value
        Fix Version/s 1.5.4 [ 11016 ]
        Hide
        mzeibig Mirko Zeibig added a comment -

        Attached a patch to change some visibilities.

        Show
        mzeibig Mirko Zeibig added a comment - Attached a patch to change some visibilities.
        mzeibig Mirko Zeibig made changes -
        Attachment patch.txt [ 14398 ]
        arjen.poutsma Arjen Poutsma made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        arjen.poutsma Arjen Poutsma made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing old issues

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing old issues
        arjen.poutsma Arjen Poutsma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        gregturn Greg Turnquist made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Assignee Arjen Poutsma [ arjen.poutsma ] Greg Turnquist [ gregturn ]
        gregturn Greg Turnquist made changes -
        Status Reopened [ 4 ] In Progress [ 3 ]
        gregturn Greg Turnquist made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Fix Version/s 2.4.1 [ 15717 ]
        Fix Version/s 1.5.4 [ 11016 ]
        Resolution Complete [ 8 ]
        gregturn Greg Turnquist made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        7h 4m 1 Arjen Poutsma 16/Jul/08 7:50 AM
        Closed Closed Reopened Reopened
        1844d 7h 49m 1 Greg Turnquist 22/May/17 2:53 PM
        Reopened Reopened In Progress In Progress
        4s 1 Greg Turnquist 22/May/17 2:53 PM
        In Progress In Progress Resolved Resolved
        13h 37m 2 Greg Turnquist 22/May/17 2:54 PM
        Resolved Resolved Closed Closed
        1387d 9h 36m 2 Greg Turnquist 22/May/17 2:54 PM

          People

          • Assignee:
            gregturn Greg Turnquist
            Reporter:
            mzeibig Mirko Zeibig
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: