Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-404

Do not transform request payload Sources when not necessary

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.4
    • Component/s: Core
    • Labels:
      None

      Description

      Currently, all request Sources are transformed into the required type. For instance, the AbstractDomPayloadEndpoint always transforms the request Source into a DOMResult, and passes that on to invokeInternal(). This is quite expensive, and not required.

      Instead, we should inspect the source, and see if it is of the required type. If so, use it directly, otherwise, transform.

        Activity

        arjen.poutsma Arjen Poutsma created issue -
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Fixed. The AbstractDomPayloadEndpoint, AbstractJDomPayloadEndpoint, AbstractDom4jPayloadEndpoint, and AbstractXomPayloadEndpoint now use this more efficient mechanism.

        The old, transforming behavior can still be obtained by setting a "alwaysTransform" boolean property to true. Default is false.

        Show
        arjen.poutsma Arjen Poutsma added a comment - Fixed. The AbstractDomPayloadEndpoint, AbstractJDomPayloadEndpoint, AbstractDom4jPayloadEndpoint, and AbstractXomPayloadEndpoint now use this more efficient mechanism. The old, transforming behavior can still be obtained by setting a "alwaysTransform" boolean property to true. Default is false.
        arjen.poutsma Arjen Poutsma made changes -
        Field Original Value New Value
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing old issues

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing old issues
        arjen.poutsma Arjen Poutsma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        4m 8s 1 Arjen Poutsma 30/Jul/08 10:15 PM
        Resolved Resolved Closed Closed
        1373d 8h 48m 1 Arjen Poutsma 04/May/12 7:03 AM

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            arjen.poutsma Arjen Poutsma
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: