Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-471

Invalid xml in SoapFaultMappingExceptionResolver example, section 5.6.1

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.5
    • Fix Version/s: 1.5.6
    • Component/s: Documentation
    • Labels:
      None

      Description

      Section 5.6.1 has invalid xml for its example of how to configure the exceptionMappers for SoapFaultMappingExceptionResolver:

      <beans>
          <bean id="exceptionResolver"
              class="org.springframework.ws.soap.server.endpoint.SoapFaultMappingExceptionResolver">
              <property name="defaultFault" value="SERVER">
              </property>
              <property name="exceptionMappings">
                  org.springframework.oxm.ValidationFailureException=CLIENT,Invalid request
              </property>
          </bean>
      </beans>

      Should be

      <beans>
          <bean id="exceptionResolver"
              class="org.springframework.ws.soap.server.endpoint.SoapFaultMappingExceptionResolver">
              <property name="defaultFault" value="SERVER">
              </property>
              <property name="exceptionMappings">
                <value>
                  org.springframework.oxm.ValidationFailureException=CLIENT,Invalid request
                </value>
              </property>
          </bean>
      </beans>

        Activity

        bhendricks Brad Hendricks created issue -
        Hide
        bhendricks Brad Hendricks added a comment -

        Eh, maybe "Major" isn't the best priority for this.

        Show
        bhendricks Brad Hendricks added a comment - Eh, maybe "Major" isn't the best priority for this.
        arjen.poutsma Arjen Poutsma made changes -
        Field Original Value New Value
        Fix Version/s 1.5.6 [ 11141 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Used wiki formatting

        Show
        arjen.poutsma Arjen Poutsma added a comment - Used wiki formatting
        arjen.poutsma Arjen Poutsma made changes -
        Description Section 5.6.1 has invalid xml for its example of how to configure the exceptionMappers for SoapFaultMappingExceptionResolver:

        <beans>
            <bean id="exceptionResolver"
                class="org.springframework.ws.soap.server.endpoint.SoapFaultMappingExceptionResolver">
                <property name="defaultFault" value="SERVER">
                </property>
                <property name="exceptionMappings">
                    org.springframework.oxm.ValidationFailureException=CLIENT,Invalid request
                </property>
            </bean>
        </beans>

        Should be

        <beans>
            <bean id="exceptionResolver"
                class="org.springframework.ws.soap.server.endpoint.SoapFaultMappingExceptionResolver">
                <property name="defaultFault" value="SERVER">
                </property>
                <property name="exceptionMappings">
                  <value>
                    org.springframework.oxm.ValidationFailureException=CLIENT,Invalid request
                  </value>
                </property>
            </bean>
        </beans>
        Section 5.6.1 has invalid xml for its example of how to configure the exceptionMappers for SoapFaultMappingExceptionResolver:

        {code:xml}
        <beans>
            <bean id="exceptionResolver"
                class="org.springframework.ws.soap.server.endpoint.SoapFaultMappingExceptionResolver">
                <property name="defaultFault" value="SERVER">
                </property>
                <property name="exceptionMappings">
                    org.springframework.oxm.ValidationFailureException=CLIENT,Invalid request
                </property>
            </bean>
        </beans>
        {code}

        Should be

        {code:xml}
        <beans>
            <bean id="exceptionResolver"
                class="org.springframework.ws.soap.server.endpoint.SoapFaultMappingExceptionResolver">
                <property name="defaultFault" value="SERVER">
                </property>
                <property name="exceptionMappings">
                  <value>
                    org.springframework.oxm.ValidationFailureException=CLIENT,Invalid request
                  </value>
                </property>
            </bean>
        </beans>
        {code}
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Thanks for spotting this, it's fixed now.

        In the future, could you please add a little note telling me what part changed? It took me 5 minutes and the help of Tareq, to spot the diff between the first and second snippet .

        Show
        arjen.poutsma Arjen Poutsma added a comment - Thanks for spotting this, it's fixed now. In the future, could you please add a little note telling me what part changed? It took me 5 minutes and the help of Tareq, to spot the diff between the first and second snippet .
        arjen.poutsma Arjen Poutsma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing old issues

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing old issues
        arjen.poutsma Arjen Poutsma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        19d 17h 18m 1 Arjen Poutsma 12/Jan/09 10:05 PM
        Resolved Resolved Closed Closed
        1207d 8h 57m 1 Arjen Poutsma 04/May/12 7:03 AM

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            bhendricks Brad Hendricks
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: