Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-525

SaajSoapMessage can get wrong SAAJ version

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.7
    • Fix Version/s: 1.5.8
    • Component/s: None
    • Labels:
      None

      Description

      The getImplementation() method of SaajSoapMessage uses SaajUtils to determine which version of SAAJ is being used. However, SaajUtils uses messageFactory.newInstance() to do this, which returns the default MessageFactory. This may not be the same MessageFactory that was used to create the SOAPMessage which was used to construct the SaajSoapMessage.

      In some cases (which is how i discovered this problem), the call to MessageFactory.newInstance() as invoked by SaajUtils fails completely. In my case it's because I'm using a JBoss environment with their WebServices stack removed, but it still looks for the JBoss SAAJ implementation and fails.

      I think SaajUtils isSaaj13() and isSaaj12() need to be rewritten to be given the MessageFactory on which to operate, rather than using the environment default.

        Activity

        skaffman Kenny MacLeod created issue -
        arjen.poutsma Arjen Poutsma made changes -
        Field Original Value New Value
        Fix Version/s 1.5.8 [ 11236 ]
        arjen.poutsma Arjen Poutsma made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        arjen.poutsma Arjen Poutsma logged work - 31/Jul/09 12:30 AM
        • Time Spent:
          2h 31m
           
          <No comment>
        arjen.poutsma Arjen Poutsma made changes -
        Remaining Estimate 0d [ 0 ]
        Time Spent 2h 31m [ 9060 ]
        arjen.poutsma Arjen Poutsma made changes -
        Resolution Fixed [ 1 ]
        Status In Progress [ 3 ] Resolved [ 5 ]
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Done. Can you try a recent snapshot and see if it works?

        Show
        arjen.poutsma Arjen Poutsma added a comment - Done. Can you try a recent snapshot and see if it works?
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing old issues

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing old issues
        arjen.poutsma Arjen Poutsma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        51d 22m 1 Arjen Poutsma 30/Jul/09 9:43 PM
        In Progress In Progress Resolved Resolved
        2h 50m 1 Arjen Poutsma 31/Jul/09 12:34 AM
        Resolved Resolved Closed Closed
        1008d 6h 29m 1 Arjen Poutsma 04/May/12 7:03 AM

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            skaffman Kenny MacLeod
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0d
              0d
              Logged:
              Time Spent - 2h 31m
              2h 31m