Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-557

Make XPathParamAnnotationMethodEndpointAdapter more extendable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 2.0 GA
    • Component/s: Core
    • Labels:
      None

      Description

      The supported datatypes for XPathParamAnnotationMethodEndpointAdapter are a bit limiting. Adding support for custom datatypes by extending the class shouldn't be very hard, but some of the key methods and fields are private, making it almost impossible to extend it.

      The attached patch turns a few fields and methods from private to protected.

      See my other issue for an example extension.

      Eivind

        Activity

        eivindt Eivind Tagseth created issue -
        Hide
        eivindt Eivind Tagseth added a comment -

        Patch making private fields and methods protected. Patch is created against 1.5.7 but seems to apply cleanly to trunk as well

        Show
        eivindt Eivind Tagseth added a comment - Patch making private fields and methods protected. Patch is created against 1.5.7 but seems to apply cleanly to trunk as well
        eivindt Eivind Tagseth made changes -
        Field Original Value New Value
        Attachment looserxpathparams.patch [ 15643 ]
        arjen.poutsma Arjen Poutsma made changes -
        Fix Version/s 1.6 [ 10981 ]
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        As of Spring-WS 2.0, the @XPathParam-annotated datatypes can now be converted into any type by using a Spring 3.0 ConversionService.

        Show
        arjen.poutsma Arjen Poutsma added a comment - As of Spring-WS 2.0, the @XPathParam-annotated datatypes can now be converted into any type by using a Spring 3.0 ConversionService.
        arjen.poutsma Arjen Poutsma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Complete [ 8 ]
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing old issues

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing old issues
        arjen.poutsma Arjen Poutsma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        495d 21h 21m 1 Arjen Poutsma 04/Jan/11 3:51 AM
        Resolved Resolved Closed Closed
        486d 3h 12m 1 Arjen Poutsma 04/May/12 7:03 AM

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            eivindt Eivind Tagseth
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: