Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-558

Use custom data types for @XPathParam annotations


    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 1.5.7
    • Fix Version/s: 2.0 GA
    • Component/s: Core
    • Labels:


      We've been using @XPathParam annotations for a while, but the supported data types are too limiting. This becomes very clear with web services being passed a user context object as their first parameter. Setting up an XPathParam annotation for each user context field in the endpoint methods spoils the elegance of using XPathParam annotations.

      The attached patch makes it possible to define your endpoint methods like this:

          public void supportedTypes(@XPathParam("/root/child/complexType") UserContext userContext) {}

      by creating a UserContextParamConverter handling the conversion from a Node to the UserContext object, and registering this converter using the converters property in the bean definition of the ExtendableXPathParamAnnotationMethodEndpointAdapter class.

      This implementation tries XPathParamAnnotationMethodEndpointAdapter's conversion support first, then asks each converter registered. If my approach makes sense, theres no reason why the existing conversion support cannot be moved into it's own ParamConverter implementation as well.

      Please let me know if this is useful or if there are changes I could make to make it more acceptable.

      The patch depends on my other issue, SWS-557.


        eivindt Eivind Tagseth created issue -
        eivindt Eivind Tagseth made changes -
        Field Original Value New Value
        Attachment extendable.patch [ 15644 ]
        arjen.poutsma Arjen Poutsma made changes -
        Fix Version/s 1.6 [ 10981 ]
        arjen.poutsma Arjen Poutsma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Complete [ 8 ]
        arjen.poutsma Arjen Poutsma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]


          • Assignee:
            arjen.poutsma Arjen Poutsma
            eivindt Eivind Tagseth
          • Votes:
            0 Vote for this issue
            1 Start watching this issue


            • Created: