Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-606

SpringPlainTextPasswordValidationCallbackHandler should import from Spring 3.0 packages

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 2.0 M2
    • Fix Version/s: None
    • Component/s: Security
    • Labels:
      None

      Description

      The current trunk version of SpringPlainTextPasswordValidationCallbackHandler looks like this: https://fisheye.springsource.org/browse/spring-ws/trunk/security/src/main/java/org/springframework/ws/soap/security/wss4j/callback/SpringPlainTextPasswordValidationCallbackHandler.java?r2=1570&u=3&r1=1570

      Its imports haven't been updated for Spring 3.0 and still list old, Spring 2.5 packages. Some of those imports:

      26	import org.springframework.security.Authentication;
      27	import org.springframework.security.AuthenticationException;
      28	import org.springframework.security.AuthenticationManager;

      They should be org.springframework.security.core.Authentication, org.springframework.security.core.AuthenticationException, org.springframework.security.authentication.AuthenticationManager etc.

      In general, most imports in this class need updating.

        Issue Links

          Activity

          Hide
          arjen.poutsma Arjen Poutsma added a comment -

          These aren't Spring 3.0 packages, but Spring Security packages. The upgrade to Spring Security 3 is planned for 2.0 M1, see SWS-559.

          Show
          arjen.poutsma Arjen Poutsma added a comment - These aren't Spring 3.0 packages, but Spring Security packages. The upgrade to Spring Security 3 is planned for 2.0 M1, see SWS-559 .
          Hide
          steveburke Steve Burke added a comment -

          This issues still exists in 2.0.0.M1

          Show
          steveburke Steve Burke added a comment - This issues still exists in 2.0.0.M1
          Hide
          arjen.poutsma Arjen Poutsma added a comment -

          Correct, as we didn't upgrade as part of M1, but will in M2, coming next week.

          Show
          arjen.poutsma Arjen Poutsma added a comment - Correct, as we didn't upgrade as part of M1, but will in M2, coming next week.
          Hide
          drakeron Ron Drake added a comment -

          Arjen, We need this capability and are in a holding pattern. Are you still on course to deliver this week? Do you have a specific release date yet? thank you.

          Show
          drakeron Ron Drake added a comment - Arjen, We need this capability and are in a holding pattern. Are you still on course to deliver this week? Do you have a specific release date yet? thank you.
          Hide
          arjen.poutsma Arjen Poutsma added a comment -

          Closing old issues

          Show
          arjen.poutsma Arjen Poutsma added a comment - Closing old issues

            People

            • Assignee:
              arjen.poutsma Arjen Poutsma
              Reporter:
              olo Aleksander Adamowski
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: