Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-648

Document Spring-WS Security exception handling

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 1.5.7, 2.0 M3
    • Fix Version/s: 2.0 RC1, 1.5.10
    • Component/s: Security
    • Labels:
      None

      Description

      In SWS-549, the exceptionHandler property was introduced into the AbstractWSSecurityInterceptor.
      This creates an inconsistency with the overall exceptionhandling architecture in Spring WS.

      Instead of introducing the EndpointExceptionResolver in this Interceptor, would it not be better to just let the exception flow up to the MessageDispatcher, where the resolvers already are configured (with sensible defaults)

      And as this is not documented anywhere unlike the exception resolving in the MessageDispatcher (http://static.springsource.org/spring-ws/sites/1.5/reference/html/server.html#server-endpoint-exception-resolver), it is too easy to miss out on or forget this extra configuration step.

      In my opinion this could be done for both the client and endpoint handleRequest/handleResponse methods by just removing the catch clauses.
      I would be happy to contribute a patch for this if needed.

        Activity

        hurragutt Paul Nyheim created issue -
        arjen.poutsma Arjen Poutsma made changes -
        Field Original Value New Value
        Assignee Arjen Poutsma [ arjen.poutsma ] Tareq Abedrabbo [ tareq ]
        arjen.poutsma Arjen Poutsma made changes -
        Assignee Tareq Abedrabbo [ tareq ] Arjen Poutsma [ arjen.poutsma ]
        arjen.poutsma Arjen Poutsma made changes -
        Resolution Won't Fix [ 2 ]
        Status Open [ 1 ] Resolved [ 5 ]
        arjen.poutsma Arjen Poutsma made changes -
        Summary Fix architectural inconsistency in Spring-WS exception handling Document Spring-WS exception handling
        arjen.poutsma Arjen Poutsma made changes -
        Status Resolved [ 5 ] Reopened [ 4 ]
        Resolution Won't Fix [ 2 ]
        arjen.poutsma Arjen Poutsma made changes -
        Fix Version/s 2.0 M4 [ 11626 ]
        Fix Version/s 1.5.10 [ 11497 ]
        arjen.poutsma Arjen Poutsma made changes -
        Summary Document Spring-WS exception handling Document Spring-WS Security exception handling
        arjen.poutsma Arjen Poutsma made changes -
        Fix Version/s 2.0 RC1 [ 11392 ]
        Fix Version/s 2.0 M4 [ 11626 ]
        arjen.poutsma Arjen Poutsma made changes -
        Status Reopened [ 4 ] In Progress [ 3 ]
        arjen.poutsma Arjen Poutsma made changes -
        Time Spent 34m [ 2040 ]
        Remaining Estimate 0d [ 0 ]
        arjen.poutsma Arjen Poutsma made changes -
        Time Spent 34m [ 2040 ] 0.15d [ 4320 ]
        arjen.poutsma Arjen Poutsma made changes -
        Resolution Complete [ 8 ]
        Status In Progress [ 3 ] Resolved [ 5 ]
        arjen.poutsma Arjen Poutsma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            hurragutt Paul Nyheim
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0d
              0d
              Logged:
              Time Spent - 0.15d
              0.15d