Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-650

AxiomSoapMessageFactory does not provide way to set properties on XMLInputFactory

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 1.5.9
    • Fix Version/s: 2.0 RC1
    • Component/s: None
    • Labels:
      None

      Description

      The AxiomSoapMessageFactory class instantiates an internally-only accessible XMLInputFactory in its constructor like this:

      inputFactory = XMLInputFactory.newInstance();

      I would like to be able to turn text coalescing off to be able to handle very large text element content (i.e. base-64 encoded binary data) but without turning off coalescing the JVM will quickly run out of memory.

      A way to configure the XMLInputFactory properties, for example to be able to specify a Map<String, Object> configurable property to pass to

      inputFactory.setProperty(key, value);

      There are many useful properties that can be configured:

      http://woodstox.codehaus.org/javadoc/stax-api/1.0/javax/xml/stream/XMLInputFactory.html

        Activity

        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        I've added a createXmlInputFactory() method, which you can override in a subclass to customize the XMLInputFactory.

        Show
        arjen.poutsma Arjen Poutsma added a comment - I've added a createXmlInputFactory() method, which you can override in a subclass to customize the XMLInputFactory.
        Hide
        msqr Matt Magoffin added a comment -

        Thanks, Arjen, but I wonder why we need to subclass just to configure these properties? I think having a createXMLInputFactory() method is useful, of course, but to make it easier to use without needing to subclass could we have a configurable Map<String, Object> property that this class can use?

        Show
        msqr Matt Magoffin added a comment - Thanks, Arjen, but I wonder why we need to subclass just to configure these properties? I think having a createXMLInputFactory() method is useful, of course, but to make it easier to use without needing to subclass could we have a configurable Map<String, Object> property that this class can use?
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing old issues

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing old issues

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            msqr Matt Magoffin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0d
              0d
              Logged:
              Time Spent - 0.05h
              0.05h