Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-714

MockWebServiceClient.sendRequest swallows StackTrace of exceptions thrown during request processing

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 2.0.3
    • Component/s: None
    • Labels:
      None

      Description

      imho there is no need to catch the exception in

      public ResponseActions sendRequest(RequestCreator requestCreator) {
      Assert.notNull(requestCreator, "'requestCreator' must not be null");
      try

      { WebServiceMessage request = requestCreator.createRequest(messageFactory); MessageContext messageContext = new DefaultMessageContext(request, messageFactory); messageReceiver.receive(messageContext); return new MockWebServiceClientResponseActions(messageContext); }

      catch (Exception ex)

      { fail(ex.getMessage()); return null; }

      }

      as this swallows any stacktrace. Why not just let the exception propagate?

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        102d 14h 27m 1 Arjen Poutsma 17/Oct/11 3:31 AM
        In Progress In Progress Resolved Resolved
        4m 37s 1 Arjen Poutsma 17/Oct/11 3:36 AM
        Resolved Resolved Closed Closed
        200d 3h 27m 1 Arjen Poutsma 04/May/12 7:03 AM

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            oakinger Erich Eichinger
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - Not Specified
              Not Specified
              Logged:
              Time Spent - 4m
              4m