Details

    • Type: Refactoring
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.3
    • Component/s: None
    • Labels:
      None

      Description

      Wss4jSecurityInterceptor implementation has design restriction making it practically imposible to extend. While working on Kerberos extension in Wss4j, I have to add new properties to configure ServicePrincipalName etc. I suggest to:

      • change scope from private to protected for method Wss4jSecurityInterceptor#initializeRequestData(messageContext) for ability to access ReqData custom properties or
      • make Wss4jHandler public so it make sense to use generic set/getOptions in subclasses

        Activity

        pkral Pavel Král created issue -
        Hide
        kyle.cronin Kyle Cronin added a comment -

        There is no way to get access to RequestData through any other means and therefore forced to use the default WSSConfig. Changing the scope of initializeRequestData would allow users to inject custom WSSconfig into the RequestData.

        Attaching a patch where initializeRequestData is protected along with an additional enhancement to configure the WSSConfig for both the WSSecurityEngine and RequestData

        Show
        kyle.cronin Kyle Cronin added a comment - There is no way to get access to RequestData through any other means and therefore forced to use the default WSSConfig . Changing the scope of initializeRequestData would allow users to inject custom WSSconfig into the RequestData . Attaching a patch where initializeRequestData is protected along with an additional enhancement to configure the WSSConfig for both the WSSecurityEngine and RequestData
        kyle.cronin Kyle Cronin made changes -
        Field Original Value New Value
        Attachment Wss4jSecurityInterceptor.patch [ 18577 ]
        Hide
        pkral Pavel Král added a comment -

        Seems to be OK, will that patch be applied to the trunk ?

        Show
        pkral Pavel Král added a comment - Seems to be OK, will that patch be applied to the trunk ?
        arjen.poutsma Arjen Poutsma made changes -
        Fix Version/s 2.0.3 [ 12197 ]
        Assignee Arjen Poutsma [ arjen.poutsma ]
        arjen.poutsma Arjen Poutsma made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        arjen.poutsma Arjen Poutsma logged work - 17/Oct/11 1:55 AM
        • Time Spent:
          0.1h
           
          <No comment>
        arjen.poutsma Arjen Poutsma made changes -
        Time Spent 0.1h [ 360 ]
        Worklog Id 28433 [ 28433 ]
        arjen.poutsma Arjen Poutsma made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Patch applied, thanks!

        Show
        arjen.poutsma Arjen Poutsma added a comment - Patch applied, thanks!
        Hide
        arjen.poutsma Arjen Poutsma added a comment -

        Closing old issues

        Show
        arjen.poutsma Arjen Poutsma added a comment - Closing old issues
        arjen.poutsma Arjen Poutsma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        73d 19h 53m 1 Arjen Poutsma 17/Oct/11 1:48 AM
        In Progress In Progress Resolved Resolved
        7m 10s 1 Arjen Poutsma 17/Oct/11 1:55 AM
        Resolved Resolved Closed Closed
        200d 5h 7m 1 Arjen Poutsma 04/May/12 7:03 AM

          People

          • Assignee:
            arjen.poutsma Arjen Poutsma
            Reporter:
            pkral Pavel Král
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - Not Specified
              Not Specified
              Logged:
              Time Spent - 0.1h
              0.1h