Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-888

HttpComponentsMessageSender does not set correctly the maximum connections per host for https connection

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Complete
    • Affects Version/s: 2.1.2, 2.2.0.RELEASE
    • Fix Version/s: 2.2.1
    • Component/s: Core
    • Labels:
      None

      Description

      The following piece of code is used to set the maximum number of connection by route in the method "setMaxConnectionsPerHost":

      HttpHost host = new HttpHost(uri.getHost(), uri.getPort(), uri.getScheme());
      HttpRoute route = new HttpRoute(host);

      This works well for http host but it does not work for https because the route will not be set as "secure". The following patch seems to work to correct this issue:

      if (uri.getScheme().equals("https")) {
      httpRoute = new HttpRoute(httpHost, null, true);
      } else {
      httpRoute = new HttpRoute(httpHost);
      }

        Activity

        amh19 Amine Halawani created issue -
        arjen.poutsma Arjen Poutsma made changes -
        Field Original Value New Value
        Assignee Greg Turnquist [ gregturn ]
        arjen.poutsma Arjen Poutsma made changes -
        Fix Version/s 2.2.1 [ 14639 ]
        gregturn Greg Turnquist made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        gregturn Greg Turnquist added a comment -

        Fixed by https://github.com/spring-projects/spring-ws/commit/8f559cfb99e64859ecbc42ba0171de503d992f40

        Added extra test assertions to confirm expected behavior.

        Show
        gregturn Greg Turnquist added a comment - Fixed by https://github.com/spring-projects/spring-ws/commit/8f559cfb99e64859ecbc42ba0171de503d992f40 Added extra test assertions to confirm expected behavior.
        gregturn Greg Turnquist made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Complete [ 8 ]
        gregturn Greg Turnquist made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        55d 6h 5m 1 Greg Turnquist 18/Mar/15 12:31 PM
        In Progress In Progress Resolved Resolved
        8m 51s 1 Greg Turnquist 18/Mar/15 12:40 PM
        Resolved Resolved Closed Closed
        6d 21h 48m 1 Greg Turnquist 25/Mar/15 10:29 AM

          People

          • Assignee:
            gregturn Greg Turnquist
            Reporter:
            amh19 Amine Halawani
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: