Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-895

AxiomHandler doesn't cleanup prefix mapping between siblings

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Complete
    • Affects Version/s: 2.2.0.RELEASE
    • Fix Version/s: 2.2.3
    • Component/s: None
    • Labels:
      None

      Description

      AxiomHandler must cleanup the prefix mapping created in startPrefixMapping(..).
      endPrefixMapping(..) should remove the mapped prefix to avoid later siblings getting previous siblings namespace definitions.

      In worst case if the later sibling doesn't define any namespaces (when covered by the parent element) it would get namespace definitions for the previous sibling.

      1. AxiomHandler.patch
        0.6 kB
        Tommy Winther
      2. AxiomHandlerTest.patch
        3 kB
        Tommy Winther

        Activity

        Hide
        gregturn Greg Turnquist added a comment -

        @Tommy

        Can you either craft a test case, or supply me with an XML example that illustrates this issue? We aren't going to submit a patch without proof of it solving a problem.

        Show
        gregturn Greg Turnquist added a comment - @Tommy Can you either craft a test case, or supply me with an XML example that illustrates this issue? We aren't going to submit a patch without proof of it solving a problem.
        Hide
        twinther Tommy Winther added a comment -

        Hi Greg,

        I've attached a test case that fails without the patch in AxiomHandler.

        Br.
        Tommy

        Show
        twinther Tommy Winther added a comment - Hi Greg, I've attached a test case that fails without the patch in AxiomHandler. Br. Tommy
        Hide
        gregturn Greg Turnquist added a comment -

        Perfect.

        Show
        gregturn Greg Turnquist added a comment - Perfect.
        Hide
        gregturn Greg Turnquist added a comment -

        Looks great! Have you signed the Spring CLA form? If not, please see https://support.springsource.com/spring_committer_signup

        Show
        gregturn Greg Turnquist added a comment - Looks great! Have you signed the Spring CLA form? If not, please see https://support.springsource.com/spring_committer_signup
        Hide
        twinther Tommy Winther added a comment -

        Sounds great. I have signed the Spring CLA just now.

        Do you have a ballpark estimate when the fix is included in a release?
        No rush though, I have patched it locally.

        Thanks,
        Tommy

        Show
        twinther Tommy Winther added a comment - Sounds great. I have signed the Spring CLA just now. Do you have a ballpark estimate when the fix is included in a release? No rush though, I have patched it locally. Thanks, Tommy
        Show
        gregturn Greg Turnquist added a comment - Fixed via https://github.com/spring-projects/spring-ws/commit/b8e4b806fa402f863d852c137f8e1b1826609f93
        Hide
        gregturn Greg Turnquist added a comment -

        I'm not sure when the next release will come out. Spring WS moves pretty slowly these days.

        Show
        gregturn Greg Turnquist added a comment - I'm not sure when the next release will come out. Spring WS moves pretty slowly these days.

          People

          • Assignee:
            gregturn Greg Turnquist
            Reporter:
            twinther Tommy Winther
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: