Uploaded image for project: 'Spring Web Services'
  1. Spring Web Services
  2. SWS-993

Numerous test failures when testing against Spring IO Platform Cairo

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Complete
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.4.1
    • Component/s: None
    • Labels:
      None

      Description

      The current head of master has numerous failures when testing its compatibility against Spring IO Platform Cairo. Details of the test failures can be found here: https://build.spring.io/browse/PLATFORM-COM-JOB1-507/test. It should also be possible to reproduce them locally by running the following (modified as necessary to match your JDK installation):

      ./gradlew springIoCheck -PJDK8_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home -PplatformVersion=Cairo-BUILD-SNAPSHOT --continue
      

        Activity

        awilkinson Andy Wilkinson created issue -
        Hide
        gregturn Greg Turnquist added a comment -

        So far, it appears to be failing purely by upgrading to 8u141. When I run things against 8u131, it passes those checks just fine.

        Show
        gregturn Greg Turnquist added a comment - So far, it appears to be failing purely by upgrading to 8u141. When I run things against 8u131, it passes those checks just fine.
        Hide
        awilkinson Andy Wilkinson added a comment -

        I don't have 8u131 installed, but with 8u121 I see the same failures as with 8u141.

        Show
        awilkinson Andy Wilkinson added a comment - I don't have 8u131 installed, but with 8u121 I see the same failures as with 8u141.
        Hide
        awilkinson Andy Wilkinson added a comment -

        Any news on this?

        Show
        awilkinson Andy Wilkinson added a comment - Any news on this?
        Hide
        gregturn Greg Turnquist added a comment -

        It appears to purely be an XML namespace issue which isn't even the scope of the breaking unit tests. I could change the expected test namespaces but I'd rather have XmlUnit instructed to ignore namespaces when asserting.

        Show
        gregturn Greg Turnquist added a comment - It appears to purely be an XML namespace issue which isn't even the scope of the breaking unit tests. I could change the expected test namespaces but I'd rather have XmlUnit instructed to ignore namespaces when asserting.
        Show
        gregturn Greg Turnquist added a comment - https://stackoverflow.com/questions/13358305/how-to-compare-two-xml-with-the-same-namespace-but-different-prefixes-using-java Appears like a solution.
        gregturn Greg Turnquist made changes -
        Field Original Value New Value
        Assignee Greg Turnquist [ gregturn ]
        gregturn Greg Turnquist made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        gregturn Greg Turnquist added a comment -

        Resolved by implementing XMLUnit "similar" check for impacted test cases.

        Show
        gregturn Greg Turnquist added a comment - Resolved by implementing XMLUnit "similar" check for impacted test cases.
        gregturn Greg Turnquist made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Fix Version/s 2.4.1 [ 15717 ]
        Resolution Complete [ 8 ]
        Show
        gregturn Greg Turnquist added a comment - Resolved via https://github.com/spring-projects/spring-ws/commit/049b86dd23cc078c7319e5c558cad1567808f265 and https://github.com/spring-projects/spring-ws/commit/208dda4635635406104fae576e332008a6cfd5c9
        gregturn Greg Turnquist made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        6d 22h 30m 1 Greg Turnquist 03/Oct/17 3:17 PM
        In Progress In Progress Resolved Resolved
        25s 1 Greg Turnquist 03/Oct/17 3:17 PM
        Resolved Resolved Closed Closed
        36s 1 Greg Turnquist 03/Oct/17 3:18 PM

          People

          • Assignee:
            gregturn Greg Turnquist
            Reporter:
            awilkinson Andy Wilkinson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: