Uploaded image for project: 'Spring XD'
  1. Spring XD
  2. XD-3754

Composed Module Child Module Validated Too Early

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: To Do
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.3.1
    • Fix Version/s: 1.3.3
    • Component/s: Runtime
    • Labels:
      None
    • Story Points:
      5
    • Rank (Obsolete):
      9223372036854775807

      Description

      module compose foo --definition "time --fixedDelay=5 | shell --command=my.sh"

      xd:>stream create bar --definition "foo | log" --deploy
      Command failed org.springframework.xd.rest.client.impl.SpringXDException: Error with option(s) for module foo of type source:
          command: may not be empty
          command: may not be null
      

      The problem stems from the fact that the options metadata validation is performed on the shell module before the property from the composed module is injected.

      Disabling the validation annotations on the metadata avoids the problem.

      //	@NotEmpty
      //	@NotNull
      public String getCommand() {
      	return command;
      }
      

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            grussell Gary Russell
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: