[BATCH-2721] Incorrect remote chunking sample in documentation Created: 14/May/18  Updated: 29/May/18  Resolved: 18/May/18

Status: Resolved
Project: Spring Batch
Component/s: Documentation
Affects Version/s: 4.0.1
Fix Version/s: 4.1.0, 4.0.2, 4.1.0.M1

Type: Bug Priority: Minor
Reporter: Mahmoud Ben Hassine Assignee: Mahmoud Ben Hassine
Resolution: Fixed Votes: 0
Labels: pull-request-submitted
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Pull Request URL: https://github.com/spring-projects/spring-batch/pull/603

 Description   

There are some minor errors in the remote chunking section of the documentation:

  • First, the diagram shows an item reader on the worker side, but in remote chunking, the reading happens on the master side and items are sent over the wire
  • The Step4 label is better if it was Step3
  • The chunkJob method of the code example takes an ItemReader as parameter but uses a method call/reference in the stepBuilderFactory.reader method
  • The chunkHandler bean is not needed on the master side
  • According to the documentation, the middleware has to be durable, but in the code example, we declare the JMS subscription as non durable: .configureListenerContainer(c -> c.subscriptionDurable(false))
  • The term "slave" is better renamed to "worker"

It would be also great to add a remote chunking sample to the spring-batch-samples module.


Generated at Tue Nov 12 01:03:25 UTC 2019 using Jira 7.13.8#713008-sha1:1606a5c1e7006e1ab135aac81f7a9566b2dbc3a6.