[ROO-1401] Better test coverage for update events Created: 15/Sep/10  Updated: 06/Oct/10  Resolved: 06/Oct/10

Status: Resolved
Project: Spring Roo
Component/s: GWT
Affects Version/s: 1.1.0.M3
Fix Version/s: 1.1.0.RC1

Type: Task Priority: Major
Reporter: Amit Manjhi Assignee: Amit Manjhi
Resolution: Deferred Votes: 0
Labels: None
Remaining Estimate: 1d
Time Spent: Not Specified
Original Estimate: 1d


 Description   

Forked from https://jira.springsource.org/browse/ROO-1238. That bug was an api change since it included getting rid of SyncResults. This bug is to track the under-reporting fix, for which we have a design doc at https://wave.google.com/wave/waveref/googlewave.com/w+ywx8dL_XC

  • Includes adding a test that exercises the example described in the design wave above.


 Comments   
Comment by Ray Ryan [ 16/Sep/10 ]

We cannot ship without this fix. Marked as a blocker.

Comment by Ray Ryan [ 20/Sep/10 ]

I think at the moment we're blessed with both over reporting and under reporting. At least it seems like every fetch is being broadcast as an update. I have no idea what the state of diff reporting is.

Comment by Amit Manjhi [ 24/Sep/10 ]

When the ValueStore first sees an entity, it broadcasts an ACQUIRE event. Subsequently, every time the entity is updated (some field either changed or a new field was fetched), it broadcasts an UPDATE event. If you are seeing events more frequently than this, there is a bug. How can I reproduce it?

Comment by Robert Vawter [ 02/Oct/10 ]

Is this resolved by the version-check in ROO-1456 that suppresses updates for previously-seen objects?

Comment by Ray Ryan [ 04/Oct/10 ]

We believe the issues are fixed, but want to land the extra tests that prove it.

Comment by Amit Manjhi [ 06/Oct/10 ]

There was some under-reporting + over-reporting going on due to a serialization bug of not sending version numbers on an update side-effect, the new reliance on version numbers, and not sending update side-effect if client is stale.

Fixed the bugs and added tests in http://code.google.com/p/google-web-toolkit/source/detail?r=8945 and http://code.google.com/p/google-web-toolkit/source/detail?r=8932

Comment by Amit Manjhi [ 06/Oct/10 ]

See previous comment.

Generated at Sun Sep 23 18:26:21 UTC 2018 using JIRA 7.9.2#79002-sha1:3bb15b68ecd99a30eb364c4c1a393359bcad6278.