[SWS-723] Wss4jSecurityInterceptor design Created: 04/Aug/11  Updated: 04/May/12  Resolved: 17/Oct/11

Status: Closed
Project: Spring Web Services
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0.3

Type: Refactoring Priority: Minor
Reporter: Pavel Král Assignee: Arjen Poutsma
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: 0.1h
Original Estimate: Not Specified

Attachments: Text File Wss4jSecurityInterceptor.patch    


Wss4jSecurityInterceptor implementation has design restriction making it practically imposible to extend. While working on Kerberos extension in Wss4j, I have to add new properties to configure ServicePrincipalName etc. I suggest to:

  • change scope from private to protected for method Wss4jSecurityInterceptor#initializeRequestData(messageContext) for ability to access ReqData custom properties or
  • make Wss4jHandler public so it make sense to use generic set/getOptions in subclasses

Comment by Kyle Cronin [ 18/Aug/11 ]

There is no way to get access to RequestData through any other means and therefore forced to use the default WSSConfig. Changing the scope of initializeRequestData would allow users to inject custom WSSconfig into the RequestData.

Attaching a patch where initializeRequestData is protected along with an additional enhancement to configure the WSSConfig for both the WSSecurityEngine and RequestData

Comment by Pavel Král [ 01/Sep/11 ]

Seems to be OK, will that patch be applied to the trunk ?

Comment by Arjen Poutsma [ 17/Oct/11 ]

Patch applied, thanks!

Comment by Arjen Poutsma [ 04/May/12 ]

Closing old issues

Generated at Tue Feb 25 21:44:43 UTC 2020 using Jira 7.13.8#713008-sha1:1606a5c1e7006e1ab135aac81f7a9566b2dbc3a6.