[SWS-895] AxiomHandler doesn't cleanup prefix mapping between siblings Created: 09/Apr/15  Updated: 15/Dec/15  Resolved: 20/Apr/15

Status: Resolved
Project: Spring Web Services
Component/s: None
Affects Version/s: 2.2.0.RELEASE
Fix Version/s: 2.2.3

Type: Bug Priority: Major
Reporter: Tommy Winther Assignee: Greg Turnquist
Resolution: Complete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File AxiomHandler.patch     Text File AxiomHandlerTest.patch    

 Description   

AxiomHandler must cleanup the prefix mapping created in startPrefixMapping(..).
endPrefixMapping(..) should remove the mapped prefix to avoid later siblings getting previous siblings namespace definitions.

In worst case if the later sibling doesn't define any namespaces (when covered by the parent element) it would get namespace definitions for the previous sibling.



 Comments   
Comment by Greg Turnquist [ 17/Apr/15 ]

@Tommy

Can you either craft a test case, or supply me with an XML example that illustrates this issue? We aren't going to submit a patch without proof of it solving a problem.

Comment by Tommy Winther [ 20/Apr/15 ]

Hi Greg,

I've attached a test case that fails without the patch in AxiomHandler.

Br.
Tommy

Comment by Greg Turnquist [ 20/Apr/15 ]

Perfect.

Comment by Greg Turnquist [ 20/Apr/15 ]

Looks great! Have you signed the Spring CLA form? If not, please see https://support.springsource.com/spring_committer_signup

Comment by Tommy Winther [ 20/Apr/15 ]

Sounds great. I have signed the Spring CLA just now.

Do you have a ballpark estimate when the fix is included in a release?
No rush though, I have patched it locally.

Thanks,
Tommy

Comment by Greg Turnquist [ 20/Apr/15 ]

Fixed via https://github.com/spring-projects/spring-ws/commit/b8e4b806fa402f863d852c137f8e1b1826609f93

Comment by Greg Turnquist [ 20/Apr/15 ]

I'm not sure when the next release will come out. Spring WS moves pretty slowly these days.

Generated at Wed Dec 13 03:33:09 UTC 2017 using JIRA 6.4.14#64029-sha1:ae256fe0fbb912241490ff1cecfb323ea0905ca5.